Replace for loops with |arraysize| with for each loops

components/autofill/core/browser/autofill_profile.cc

Index: components/autofill/core/browser/autofill_profile.cc
diff --git a/components/autofill/core/browser/autofill_profile.cc b/components/autofill/core/browser/autofill_profile.cc
index 602cf1bf7bb2e320f732ade1783149cd70ace8c7..4668539f174378de508208a1d46b52eb00c087cb 100644
--- a/components/autofill/core/browser/autofill_profile.cc
+++ b/components/autofill/core/browser/autofill_profile.cc
@@ -354,8 +354,8 @@ int AutofillProfile::Compare(const AutofillProfile& profile) const {
       PHONE_HOME_WHOLE_NUMBER,
   };
 
-  for (size_t i = 0; i < arraysize(types); ++i) {
-    int comparison = GetRawInfo(types[i]).compare(profile.GetRawInfo(types[i]));
+  for (const auto& type : types) {

[vabr (Chromium), 2016/10/17 07:40:33]

const auto& -> ServerFieldType

(1) Replacing auto with the (simple-named) type to make it clearer.

(2) Making a const ref to a value copy for an integer-like type, because it
removes one layer of indirection while preserving copying costs.

[jdoerrie, 2016/10/17 08:42:27]

Done.

+    int comparison = GetRawInfo(type).compare(profile.GetRawInfo(type));
     if (comparison != 0) {
       return comparison;
     }