Replace for loops with |arraysize| with for each loops

components/autofill/content/renderer/form_cache.cc

Index: components/autofill/content/renderer/form_cache.cc
diff --git a/components/autofill/content/renderer/form_cache.cc b/components/autofill/content/renderer/form_cache.cc
index 0ff07229ed661ac48169382c8d6f28bc9fd18043..7a2297f7b182a623943c3e430287bd7c8b96bcea 100644
--- a/components/autofill/content/renderer/form_cache.cc
+++ b/components/autofill/content/renderer/form_cache.cc
@@ -45,10 +45,10 @@ void LogDeprecationMessages(const WebFormControlElement& element) {
           element.getAttribute("autocomplete")));
 
   static const char* const deprecated[] = { "region", "locality" };
-  for (size_t i = 0; i < arraysize(deprecated); ++i) {
-    if (autocomplete_attribute.find(deprecated[i]) == std::string::npos)
+  for (const auto& str : deprecated) {

[vabr (Chromium), 2016/10/17 07:40:33]

When |str| is a pointer, we prefer to spell it out (* instead of &), see
http://crbug.com/554600. So a first step would be to have const auto*. Also,
while the pointer is the same size as a reference to copy, but having the
pointer reduces one step of indirection compared to the reference (looking up
what is being referenced) inside the loop body.

Second, the type |char| is simple enough to have no need for auto. Please just
use "const char* str: deprecated", it allows better understanding of the type
from that line without increasing code complexity.

[jdoerrie, 2016/10/17 08:42:27]

Done.

+    if (autocomplete_attribute.find(str) == std::string::npos)
       continue;
-    std::string msg = std::string("autocomplete='") + deprecated[i] +
+    std::string msg = std::string("autocomplete='") + str +
         "' is deprecated and will soon be ignored. See http://goo.gl/YjeSsW";
     WebConsoleMessage console_message = WebConsoleMessage(
         WebConsoleMessage::LevelWarning,