Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: components/autofill/core/browser/validation_unittest.cc

Issue 2417783004: Replace for loops with |arraysize| with for each loops (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "components/autofill/core/browser/validation.h" 10 #include "components/autofill/core/browser/validation.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 "user@", 85 "user@",
86 "user@=example.com" 86 "user@=example.com"
87 }; 87 };
88 const char kAmericanExpressCard[] = "341111111111111"; 88 const char kAmericanExpressCard[] = "341111111111111";
89 const char kVisaCard[] = "4111111111111111"; 89 const char kVisaCard[] = "4111111111111111";
90 const char kAmericanExpressCVC[] = "1234"; 90 const char kAmericanExpressCVC[] = "1234";
91 const char kVisaCVC[] = "123"; 91 const char kVisaCVC[] = "123";
92 } // namespace 92 } // namespace
93 93
94 TEST(AutofillValidation, IsValidCreditCardNumber) { 94 TEST(AutofillValidation, IsValidCreditCardNumber) {
95 for (size_t i = 0; i < arraysize(kValidNumbers); ++i) { 95 for (const auto& valid_number : kValidNumbers) {
vabr (Chromium) 2016/10/17 07:40:33 const char* (Also below in this file.)
jdoerrie 2016/10/17 08:42:27 Done.
96 SCOPED_TRACE(kValidNumbers[i]); 96 SCOPED_TRACE(valid_number);
97 EXPECT_TRUE( 97 EXPECT_TRUE(IsValidCreditCardNumber(ASCIIToUTF16(valid_number)));
98 IsValidCreditCardNumber(ASCIIToUTF16(kValidNumbers[i])));
99 } 98 }
100 for (size_t i = 0; i < arraysize(kInvalidNumbers); ++i) { 99 for (const auto& invalid_number : kInvalidNumbers) {
101 SCOPED_TRACE(kInvalidNumbers[i]); 100 SCOPED_TRACE(invalid_number);
102 EXPECT_FALSE(IsValidCreditCardNumber(ASCIIToUTF16(kInvalidNumbers[i]))); 101 EXPECT_FALSE(IsValidCreditCardNumber(ASCIIToUTF16(invalid_number)));
103 } 102 }
104 } 103 }
105 104
106 TEST(AutofillValidation, IsValidCreditCardIntExpirationDate) { 105 TEST(AutofillValidation, IsValidCreditCardIntExpirationDate) {
107 base::Time now; 106 base::Time now;
108 ASSERT_TRUE(base::Time::FromString(kCurrentDate, &now)); 107 ASSERT_TRUE(base::Time::FromString(kCurrentDate, &now));
109 108
110 for (size_t i = 0; i < arraysize(kValidCreditCardIntExpirationDate); ++i) { 109 for (const IntExpirationDate& data : kValidCreditCardIntExpirationDate) {
111 const IntExpirationDate& data = kValidCreditCardIntExpirationDate[i];
112 SCOPED_TRACE(data.year); 110 SCOPED_TRACE(data.year);
113 SCOPED_TRACE(data.month); 111 SCOPED_TRACE(data.month);
114 EXPECT_TRUE(IsValidCreditCardExpirationDate(data.year, data.month, now)); 112 EXPECT_TRUE(IsValidCreditCardExpirationDate(data.year, data.month, now));
115 } 113 }
116 for (size_t i = 0; i < arraysize(kInvalidCreditCardIntExpirationDate); ++i) { 114 for (const IntExpirationDate& data : kInvalidCreditCardIntExpirationDate) {
117 const IntExpirationDate& data = kInvalidCreditCardIntExpirationDate[i];
118 SCOPED_TRACE(data.year); 115 SCOPED_TRACE(data.year);
119 SCOPED_TRACE(data.month); 116 SCOPED_TRACE(data.month);
120 EXPECT_TRUE(!IsValidCreditCardExpirationDate(data.year, data.month, now)); 117 EXPECT_TRUE(!IsValidCreditCardExpirationDate(data.year, data.month, now));
121 } 118 }
122 } 119 }
123 TEST(AutofillValidation, IsValidCreditCardSecurityCode) { 120 TEST(AutofillValidation, IsValidCreditCardSecurityCode) {
124 for (size_t i = 0; i < arraysize(kValidCreditCardSecurityCode); ++i) { 121 for (const auto& valid_code : kValidCreditCardSecurityCode) {
125 SCOPED_TRACE(kValidCreditCardSecurityCode[i]); 122 SCOPED_TRACE(valid_code);
126 EXPECT_TRUE(IsValidCreditCardSecurityCode( 123 EXPECT_TRUE(IsValidCreditCardSecurityCode(ASCIIToUTF16(valid_code)));
127 ASCIIToUTF16(kValidCreditCardSecurityCode[i])));
128 } 124 }
129 for (size_t i = 0; i < arraysize(kInvalidCreditCardSecurityCode); ++i) { 125 for (const auto& invalid_code : kInvalidCreditCardSecurityCode) {
130 SCOPED_TRACE(kInvalidCreditCardSecurityCode[i]); 126 SCOPED_TRACE(invalid_code);
131 EXPECT_FALSE(IsValidCreditCardSecurityCode( 127 EXPECT_FALSE(IsValidCreditCardSecurityCode(ASCIIToUTF16(invalid_code)));
132 ASCIIToUTF16(kInvalidCreditCardSecurityCode[i])));
133 } 128 }
134 } 129 }
135 130
136 TEST(AutofillValidation, IsValidEmailAddress) { 131 TEST(AutofillValidation, IsValidEmailAddress) {
137 for (size_t i = 0; i < arraysize(kValidEmailAddress); ++i) { 132 for (const auto& valid_email : kValidEmailAddress) {
138 SCOPED_TRACE(kValidEmailAddress[i]); 133 SCOPED_TRACE(valid_email);
139 EXPECT_TRUE(IsValidEmailAddress(ASCIIToUTF16(kValidEmailAddress[i]))); 134 EXPECT_TRUE(IsValidEmailAddress(ASCIIToUTF16(valid_email)));
140 } 135 }
141 for (size_t i = 0; i < arraysize(kInvalidEmailAddress); ++i) { 136 for (const auto& invalid_email : kInvalidEmailAddress) {
142 SCOPED_TRACE(kInvalidEmailAddress[i]); 137 SCOPED_TRACE(invalid_email);
143 EXPECT_FALSE(IsValidEmailAddress(ASCIIToUTF16(kInvalidEmailAddress[i]))); 138 EXPECT_FALSE(IsValidEmailAddress(ASCIIToUTF16(invalid_email)));
144 } 139 }
145 } 140 }
146 141
147 TEST(AutofillValidation, IsValidCreditCardSecurityCodeWithNumber) { 142 TEST(AutofillValidation, IsValidCreditCardSecurityCodeWithNumber) {
148 EXPECT_TRUE(IsValidCreditCardSecurityCode( 143 EXPECT_TRUE(IsValidCreditCardSecurityCode(
149 ASCIIToUTF16(kAmericanExpressCVC), ASCIIToUTF16(kAmericanExpressCard))); 144 ASCIIToUTF16(kAmericanExpressCVC), ASCIIToUTF16(kAmericanExpressCard)));
150 EXPECT_TRUE(IsValidCreditCardSecurityCode( 145 EXPECT_TRUE(IsValidCreditCardSecurityCode(
151 ASCIIToUTF16(kVisaCVC), ASCIIToUTF16(kVisaCard))); 146 ASCIIToUTF16(kVisaCVC), ASCIIToUTF16(kVisaCard)));
152 EXPECT_FALSE(IsValidCreditCardSecurityCode( 147 EXPECT_FALSE(IsValidCreditCardSecurityCode(
153 ASCIIToUTF16(kVisaCVC), ASCIIToUTF16(kAmericanExpressCard))); 148 ASCIIToUTF16(kVisaCVC), ASCIIToUTF16(kAmericanExpressCard)));
154 EXPECT_FALSE(IsValidCreditCardSecurityCode( 149 EXPECT_FALSE(IsValidCreditCardSecurityCode(
155 ASCIIToUTF16(kAmericanExpressCVC), ASCIIToUTF16(kVisaCard))); 150 ASCIIToUTF16(kAmericanExpressCVC), ASCIIToUTF16(kVisaCard)));
156 EXPECT_TRUE(IsValidCreditCardSecurityCode( 151 EXPECT_TRUE(IsValidCreditCardSecurityCode(
157 ASCIIToUTF16(kVisaCVC), ASCIIToUTF16(kInvalidNumbers[0]))); 152 ASCIIToUTF16(kVisaCVC), ASCIIToUTF16(kInvalidNumbers[0])));
158 EXPECT_FALSE(IsValidCreditCardSecurityCode( 153 EXPECT_FALSE(IsValidCreditCardSecurityCode(
159 ASCIIToUTF16(kAmericanExpressCVC), ASCIIToUTF16(kInvalidNumbers[0]))); 154 ASCIIToUTF16(kAmericanExpressCVC), ASCIIToUTF16(kInvalidNumbers[0])));
160 } 155 }
161 156
162 } // namespace autofill 157 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698