Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Issue 2417773004: [wasm] Reduce usage of old Wasm.* API in JS tests. (Closed)

Created:
4 years, 2 months ago by titzer
Modified:
4 years, 2 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Reduce usage of old Wasm.* API in JS tests. BUG= Committed: https://crrev.com/283b31f57c03d8cdeb229774926f549265adf8c3 Cr-Commit-Position: refs/heads/master@{#40282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -78 lines) Patch
M test/mjsunit/wasm/data-segments.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/exceptions.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 chunk +0 lines, -3 lines 0 comments Download
D test/mjsunit/wasm/verify-function-basic-errors.js View 1 chunk +0 lines, -18 lines 0 comments Download
D test/mjsunit/wasm/verify-function-simple.js View 1 chunk +0 lines, -38 lines 0 comments Download
M test/mjsunit/wasm/verify-module-basic-errors.js View 1 chunk +10 lines, -10 lines 0 comments Download
M test/mjsunit/wasm/wasm-object-api.js View 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
titzer
PTAL
4 years, 2 months ago (2016-10-13 16:51:44 UTC) #7
bradnelson
lgtm
4 years, 2 months ago (2016-10-13 16:53:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417773004/1
4 years, 2 months ago (2016-10-13 16:53:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 16:55:32 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 16:56:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/283b31f57c03d8cdeb229774926f549265adf8c3
Cr-Commit-Position: refs/heads/master@{#40282}

Powered by Google App Engine
This is Rietveld 408576698