Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2417753003: Input element: Fix the dirty value flag after type change. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Input element: Fix the dirty value flag after type change. When the input type was changed from type=hidden, of which value-mode is "default", to type=text, of which value-mode is "value", we incorrectly set dirty value flag to true. This CL fixes it. Specification: https://html.spec.whatwg.org/multipage/forms.html#input-type-change BUG=655412 Committed: https://crrev.com/2cabef4e7d4a0b298a114add1298920cc0cfb321 Cr-Commit-Position: refs/heads/master@{#424936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/input-type-change3.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/input-type-change3-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
keishi@, would you review this please?
4 years, 2 months ago (2016-10-13 01:35:39 UTC) #4
keishi
LGTM
4 years, 2 months ago (2016-10-13 01:39:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417753003/1
4 years, 2 months ago (2016-10-13 01:48:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 01:54:32 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 01:56:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cabef4e7d4a0b298a114add1298920cc0cfb321
Cr-Commit-Position: refs/heads/master@{#424936}

Powered by Google App Engine
This is Rietveld 408576698