Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2417743004: Add option to print all exceptions (Closed)

Created:
4 years, 2 months ago by Clemens Hammacher
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add option to print all exceptions When DevTools calls to JavaScript, it often ignores exceptions and just fails since no value was returned. The new --print-all-exceptions flag makes it easy to spot the location and the reason for the thrown exception. R=titzer@chromium.org Committed: https://crrev.com/8bb1e6d06b8c196f4b2ebc75a5b3142dd886e4f6 Cr-Commit-Position: refs/heads/master@{#40340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Clemens Hammacher
4 years, 2 months ago (2016-10-14 10:23:57 UTC) #4
titzer
Nice idea. LGTM
4 years, 2 months ago (2016-10-15 10:47:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417743004/1
4 years, 2 months ago (2016-10-17 07:16:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417743004/1
4 years, 2 months ago (2016-10-17 08:05:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 08:37:32 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 08:37:52 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bb1e6d06b8c196f4b2ebc75a5b3142dd886e4f6
Cr-Commit-Position: refs/heads/master@{#40340}

Powered by Google App Engine
This is Rietveld 408576698