Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2417723002: [Devtools] Bug fix of event dividers not showing in network panel (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
500 addFilmStripFrames: function(times) 500 addFilmStripFrames: function(times)
501 { 501 {
502 this._columns.addEventDividers(times, "network-frame-divider"); 502 this._columns.addEventDividers(times, "network-frame-divider");
503 }, 503 },
504 504
505 /** 505 /**
506 * @param {number} time 506 * @param {number} time
507 */ 507 */
508 selectFilmStripFrame: function(time) 508 selectFilmStripFrame: function(time)
509 { 509 {
510 for (var divider of this._eventDividers) 510 this._columns.selectFilmStripFrame(time);
511 divider.element.classList.toggle("network-frame-divider-selected", d ivider.time === time);
512 }, 511 },
513 512
514 clearFilmStripFrame: function() 513 clearFilmStripFrame: function()
515 { 514 {
516 for (var divider of this._eventDividers) 515 this._columns.clearFilmStripFrame();
517 divider.element.classList.toggle("network-frame-divider-selected", f alse);
518 }, 516 },
519 517
520 _refreshIfNeeded: function() 518 _refreshIfNeeded: function()
521 { 519 {
522 if (this._needsRefresh) 520 if (this._needsRefresh)
523 this.refresh(); 521 this.refresh();
524 }, 522 },
525 523
526 _invalidateAllItems: function() 524 _invalidateAllItems: function()
527 { 525 {
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 var nodes = this._nodesByRequestId.valuesArray(); 690 var nodes = this._nodesByRequestId.valuesArray();
693 for (var i = 0; i < nodes.length; ++i) 691 for (var i = 0; i < nodes.length; ++i)
694 nodes[i].dispose(); 692 nodes[i].dispose();
695 693
696 this._nodesByRequestId.clear(); 694 this._nodesByRequestId.clear();
697 this._staleRequestIds = {}; 695 this._staleRequestIds = {};
698 this._resetSuggestionBuilder(); 696 this._resetSuggestionBuilder();
699 697
700 this._mainRequestLoadTime = -1; 698 this._mainRequestLoadTime = -1;
701 this._mainRequestDOMContentLoadedTime = -1; 699 this._mainRequestDOMContentLoadedTime = -1;
702 this._eventDividers = [];
703 700
704 if (this._dataGrid) { 701 if (this._dataGrid) {
705 this._dataGrid.rootNode().removeChildren(); 702 this._dataGrid.rootNode().removeChildren();
706 this._updateSummaryBar(); 703 this._updateSummaryBar();
707 } 704 }
708 }, 705 },
709 706
710 /** 707 /**
711 * @param {string} filterString 708 * @param {string} filterString
712 */ 709 */
(...skipping 1104 matching lines...) Expand 10 before | Expand all | Expand 10 after
1817 * @return {boolean} 1814 * @return {boolean}
1818 */ 1815 */
1819 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request) 1816 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request)
1820 { 1817 {
1821 if (request.issueTime() > windowEnd) 1818 if (request.issueTime() > windowEnd)
1822 return false; 1819 return false;
1823 if (request.endTime !== -1 && request.endTime < windowStart) 1820 if (request.endTime !== -1 && request.endTime < windowStart)
1824 return false; 1821 return false;
1825 return true; 1822 return true;
1826 } 1823 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698