DevTools: introduce a stub for the new audits panel (behind experiment).

DevTools: introduce a stub for the new audits panel (behind experiment).

BUG=656055
Committed: https://crrev.com/332f59dc06cddbdb4a0fa647b11960141e96af2c
Cr-Commit-Position: refs/heads/master@{#425506}

[pfeldman, 2016-10-14 01:20:10]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-10-14 03:14:58]

lgtm

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:1: //
Copyright (c) 2015 The Chromium Authors. All rights reserved.
Wrong copyright.

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
(right):

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js:14:
start: function()
@return

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js:20:
stop: function()
@return

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js:27:
* @override
@return

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/Main.js:84:
Runtime.experiments.register("audits2", "Audits 2", true);
2.0 :-)

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js
(right):

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js:74:
console.error("Could not initialize service");
nit: let's print serviceName as well

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js:325: var
callback;
Our pattern has var fulfill, not callback.

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/worker_service/ServiceDispatcher.js
(right):

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/worker_service/ServiceDispatcher.js:207:
var worker = /** @type {!Object} */(self);
@type {!Worker}

[pfeldman, 2016-10-14 17:26:01]

Description was changed from

==========
DevTools: introduce a stub for the new audits panel (behind experiment).
==========

to

==========
DevTools: introduce a stub for the new audits panel (behind experiment).

BUG=656055
==========

[pfeldman, 2016-10-14 17:29:20]

all done, except for one.

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/worker_service/ServiceDispatcher.js
(right):

https://codereview.chromium.org/2417703006/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/worker_service/ServiceDispatcher.js:207:
var worker = /** @type {!Object} */(self);
On 2016/10/14 03:14:58, dgozman wrote:
> @type {!Worker}

JSCompiler won't let you do that...

[pfeldman, 2016-10-14 17:35:04]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-10-14 17:35:05]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2417703006/#ps20001
(title: "review comments addressed")

[commit-bot: I haz the power, 2016-10-14 17:35:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 17:48:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 17:48:13]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-10-14 18:45:45]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-10-14 18:45:46]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2417703006/#ps40001
(title: "rebaselined")

[commit-bot: I haz the power, 2016-10-14 18:46:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 18:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 18:57:55]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-10-14 20:06:41]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-10-14 20:06:41]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2417703006/#ps60001
(title: "missing file added.")

[commit-bot: I haz the power, 2016-10-14 20:07:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 23:15:34]

Description was changed from

==========
DevTools: introduce a stub for the new audits panel (behind experiment).

BUG=656055
==========

to

==========
DevTools: introduce a stub for the new audits panel (behind experiment).

BUG=656055
==========

[commit-bot: I haz the power, 2016-10-14 23:15:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-14 23:17:54]

Description was changed from

==========
DevTools: introduce a stub for the new audits panel (behind experiment).

BUG=656055
==========

to

==========
DevTools: introduce a stub for the new audits panel (behind experiment).

BUG=656055

Committed: https://crrev.com/332f59dc06cddbdb4a0fa647b11960141e96af2c
Cr-Commit-Position: refs/heads/master@{#425506}
==========

[commit-bot: I haz the power, 2016-10-14 23:17:55]

Patchset 4 (id:??) landed as
https://crrev.com/332f59dc06cddbdb4a0fa647b11960141e96af2c
Cr-Commit-Position: refs/heads/master@{#425506}