Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: BUILD.gn

Issue 2417703003: parser fuzzer and parser shell should also work in component builds (Closed)
Patch Set: updates Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parsing/parse-info.h » ('j') | src/parsing/parser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 83816842fb424de68d9f543b6cdb9dee9963b029..5b6a752839586ac5d7110f8cfa572d1426f0503e 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -2389,32 +2389,6 @@ v8_source_set("fuzzer_support") {
]
}
-# Used by fuzzers that would require exposing too many symbols for a proper
-# component build.
-v8_source_set("fuzzer_support_nocomponent") {
- visibility = [ ":*" ] # Only targets in this file can depend on this.
-
- sources = [
- "test/fuzzer/fuzzer-support.cc",
- "test/fuzzer/fuzzer-support.h",
- ]
-
- configs = [ ":internal_config_base" ]
-
- deps = [
- ":v8_maybe_snapshot",
- ]
-
- if (is_component_build) {
- defines = [ "BUILDING_V8_SHARED" ]
- }
-
- public_deps = [
- ":v8_libbase",
- ":v8_libplatform",
- ]
-}
-
v8_source_set("simple_fuzzer") {
sources = [
"test/fuzzer/fuzzer.cc",
@@ -2651,36 +2625,16 @@ v8_executable("v8_parser_shell") {
]
deps = [
+ ":v8",
":v8_libbase",
":v8_libplatform",
"//build/config/sanitizers:deps",
"//build/win:default_exe_manifest",
]
- defines = []
-
- if (is_component_build) {
- # v8_parser_shell can't be built against a shared library, so we
- # need to depend on the underlying static target in that case.
- deps += [ ":v8_maybe_snapshot" ]
- defines += [ "BUILDING_V8_SHARED" ]
- } else {
- deps += [ ":v8" ]
- }
-
if (v8_enable_i18n_support) {
deps += [ "//third_party/icu" ]
}
-
- if (is_win) {
- # Suppress warnings about importing locally defined symbols.
- if (is_component_build) {
- ldflags = [
- "/ignore:4049",
- "/ignore:4217",
- ]
- }
- }
}
if (want_v8_shell) {
@@ -2748,13 +2702,9 @@ v8_source_set("parser_fuzzer") {
]
deps = [
- ":fuzzer_support_nocomponent",
+ ":fuzzer_support",
]
- if (is_component_build) {
- defines = [ "BUILDING_V8_SHARED" ]
- }
-
configs = [
":external_config",
":internal_config_base",
« no previous file with comments | « no previous file | src/parsing/parse-info.h » ('j') | src/parsing/parser.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698