parser fuzzer and parser shell should also work in component builds

parser fuzzer and parser shell should also work in component builds

R=machenbach@chromium.org,jgruber@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe

Committed: https://crrev.com/aee0a2573bb87a5accdadd234151ebb168248967
Cr-Commit-Position: refs/heads/master@{#40297}

[jochen (gone - plz use gerrit), 2016-10-13 19:07:18]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 19:07:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 19:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:14:39]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jochen (gone - plz use gerrit), 2016-10-14 06:44:16]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 06:44:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 06:53:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 06:53:11]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jochen (gone - plz use gerrit), 2016-10-14 07:26:11]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 07:26:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-10-14 07:31:37]

jochen@chromium.org changed reviewers:
+ marja@chromium.org

[jochen (gone - plz use gerrit), 2016-10-14 07:31:37]

ptal

[Michael Achenbach, 2016-10-14 07:34:28]

Description was changed from

==========
parser fuzzer and parser shell should also work in component builds

R=machenbach@chromium.org,jgruber@chromium.org
BUG=
==========

to

==========
parser fuzzer and parser shell should also work in component builds

R=machenbach@chromium.org,jgruber@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg
==========

[Michael Achenbach, 2016-10-14 07:35:07]

I added win and mac trybots to the CQ, as the release bots don't use component
builds.

[marja, 2016-10-14 07:36:31]

https://codereview.chromium.org/2417703003/diff/40001/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2417703003/diff/40001/src/parsing/parser.h#ne...
src/parsing/parser.h:1112: class ParserTarget BASE_EMBEDDED {
Could these now be inner classes of Parser?

[jochen (gone - plz use gerrit), 2016-10-14 07:37:52]

https://codereview.chromium.org/2417703003/diff/40001/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2417703003/diff/40001/src/parsing/parser.h#ne...
src/parsing/parser.h:1112: class ParserTarget BASE_EMBEDDED {
On 2016/10/14 at 07:36:30, marja wrote:
> Could these now be inner classes of Parser?

possibly? I tried to do only symbol visibility related changes, and since the
ParserBase template refers to ParserTarget, MSVS was no longer happy with just
the forward declaration

[marja, 2016-10-14 07:43:44]

lgtm

(Probably the inner class thing doesn't work because we cannot use a
forward-declared inner class in ParserTypes.)

((Not sure if that could be solved by putting ParserTypes after Parser.))

[Michael Achenbach, 2016-10-14 07:46:33]

Description was changed from

==========
parser fuzzer and parser shell should also work in component builds

R=machenbach@chromium.org,jgruber@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg
==========

to

==========
parser fuzzer and parser shell should also work in component builds

R=machenbach@chromium.org,jgruber@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe
==========

[Michael Achenbach, 2016-10-14 07:48:56]

lgtm

[jochen (gone - plz use gerrit), 2016-10-14 07:49:14]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-10-14 07:49:17]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-10-14 07:49:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-14 07:54:48]

nice!

[commit-bot: I haz the power, 2016-10-14 08:35:27]

Description was changed from

==========
parser fuzzer and parser shell should also work in component builds

R=machenbach@chromium.org,jgruber@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe
==========

to

==========
parser fuzzer and parser shell should also work in component builds

R=machenbach@chromium.org,jgruber@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe
==========

[commit-bot: I haz the power, 2016-10-14 08:35:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-14 08:36:00]

Description was changed from

==========
parser fuzzer and parser shell should also work in component builds

R=machenbach@chromium.org,jgruber@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe
==========

to

==========
parser fuzzer and parser shell should also work in component builds

R=machenbach@chromium.org,jgruber@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe

Committed: https://crrev.com/aee0a2573bb87a5accdadd234151ebb168248967
Cr-Commit-Position: refs/heads/master@{#40297}
==========

[commit-bot: I haz the power, 2016-10-14 08:36:02]

Patchset 3 (id:??) landed as
https://crrev.com/aee0a2573bb87a5accdadd234151ebb168248967
Cr-Commit-Position: refs/heads/master@{#40297}