Fixed crash when chrome.runtime.reload() is called with app windows open

apps/app_window_contents.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/app_window_contents.h"
 
 #include "apps/native_app_window.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/app_window.h"
@@ skipping 78 matching lines @@
   update.width.reset(new int(bounds.width()));
   update.height.reset(new int(bounds.height()));
   dictionary->Set("bounds", update.ToValue().release());
   dictionary->SetBoolean("fullscreen",
                          native_app_window->IsFullscreenOrPending());
   dictionary->SetBoolean("minimized", native_app_window->IsMinimized());
   dictionary->SetBoolean("maximized", native_app_window->IsMaximized());
 
   content::RenderViewHost* rvh = web_contents_->GetRenderViewHost();
   rvh->Send(new ExtensionMsg_MessageInvoke(rvh->GetRoutingID(),
-                                           host_->extension()->id(),
+                                           host_->extension_id(),

[benwells, 2013/09/20 07:35:31]

huh, I was just looking at this today due to
https://code.google.com/p/chromium/issues/detail?id=265922.

TBH I don't like the way there is extension_id, which is to be used when
extension is NULL. Feels dodgy.

[tmdiep, 2013/09/20 11:07:36]

Darn, if I had waited a bit longer this could have been fixed for me :)

If the ShellWindow sets the extension pointer to NULL when the extension
unloads, perhaps we can check and not forward the message to the render view if
it is not necessary to, since the window is closing.

                                            "app.window",
                                            "updateAppWindowProperties",
                                            args,
                                            false));
 }
 
 void AppWindowContents::NativeWindowClosed() {
   content::RenderViewHost* rvh = web_contents_->GetRenderViewHost();
   rvh->Send(new ExtensionMsg_AppWindowClosed(rvh->GetRoutingID()));
 }
@@ skipping 58 matching lines @@
     content::RenderViewHost* rvh) {
   DCHECK(rvh);
   content::BrowserThread::PostTask(
       content::BrowserThread::IO, FROM_HERE,
       base::Bind(&content::ResourceDispatcherHost::BlockRequestsForRoute,
                  base::Unretained(content::ResourceDispatcherHost::Get()),
                  rvh->GetProcess()->GetID(), rvh->GetRoutingID()));
 }
 
 }  // namespace apps