Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2417693003: Upstream utilities to select icon to display in omnibox. (Closed)

Created:
4 years, 2 months ago by sdefresne
Modified:
4 years, 2 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream utilities to select icon to display in omnibox. BUG=648281 Committed: https://crrev.com/9bef2e8794b011307990a194f09937839200bd23 Cr-Commit-Position: refs/heads/master@{#425089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -2 lines) Patch
A + ios/chrome/app/theme/default_100_percent/controlled_setting_mandatory.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_100_percent/omnibox_history.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_100_percent/omnibox_history_incognito.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_100_percent/omnibox_http.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_100_percent/omnibox_http_incognito.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_100_percent/omnibox_https_invalid.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_100_percent/omnibox_https_valid.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_100_percent/omnibox_search.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_100_percent/omnibox_search_incognito.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_100_percent/omnibox_star.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_100_percent/omnibox_star_incognito.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_200_percent/controlled_setting_mandatory.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_200_percent/omnibox_history.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_200_percent/omnibox_history_incognito.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_200_percent/omnibox_http.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_200_percent/omnibox_http_incognito.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_200_percent/omnibox_https_invalid.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_200_percent/omnibox_https_valid.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_200_percent/omnibox_search.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_200_percent/omnibox_search_incognito.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_200_percent/omnibox_star.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_200_percent/omnibox_star_incognito.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_300_percent/controlled_setting_mandatory.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_300_percent/omnibox_history.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_300_percent/omnibox_history_incognito.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_300_percent/omnibox_http.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_300_percent/omnibox_http_incognito.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_300_percent/omnibox_https_invalid.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_300_percent/omnibox_https_valid.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_300_percent/omnibox_search.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_300_percent/omnibox_search_incognito.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_300_percent/omnibox_star.png View Binary file 0 comments Download
A + ios/chrome/app/theme/default_300_percent/omnibox_star_incognito.png View Binary file 0 comments Download
M ios/chrome/app/theme/ios_theme_resources.grd View 1 chunk +12 lines, -0 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
A ios/chrome/browser/ui/omnibox/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/omnibox/omnibox_util.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/omnibox/omnibox_util.cc View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sdefresne
Please take a look.
4 years, 2 months ago (2016-10-13 00:06:59 UTC) #6
sdefresne
Ping?
4 years, 2 months ago (2016-10-13 17:20:11 UTC) #7
rohitrao (ping after 24h)
lgtm
4 years, 2 months ago (2016-10-13 17:39:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417693003/1
4 years, 2 months ago (2016-10-13 18:00:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 18:09:56 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 18:12:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bef2e8794b011307990a194f09937839200bd23
Cr-Commit-Position: refs/heads/master@{#425089}

Powered by Google App Engine
This is Rietveld 408576698