Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h

Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs (Closed)
Patch Set: Rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
index 87d249eb30ecdd268c56a8965caf04a362a2f36c..d237318c047b48fc702cabaae2fcb491cc308c58 100644
--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
@@ -58,7 +58,13 @@ class MimeHandlerViewGuest :
static const char Type[];
+ // BrowserPluginGuestDelegate overrides.
bool CanUseCrossProcessFrames() override;
+ bool CanBeEmbeddedInsideCrossProcessFrames() override;
+ content::RenderWidgetHost* GetOwnerRenderWidgetHost() override;
+ content::SiteInstance* GetOwnerSiteInstance() override;
+
+ void SetEmbedderFrame(int process_id, int routing_id);
protected:
explicit MimeHandlerViewGuest(content::WebContents* owner_web_contents);
@@ -89,6 +95,7 @@ class MimeHandlerViewGuest :
content::JavaScriptDialogManager* GetJavaScriptDialogManager(
content::WebContents* source) final;
bool SaveFrame(const GURL& url, const content::Referrer& referrer) final;
+ void OnRenderFrameHostDeleted(int process_id, int routing_id) final;
// content::WebContentsObserver implementation.
void DocumentOnLoadCompletedInMainFrame() final;
@@ -100,6 +107,10 @@ class MimeHandlerViewGuest :
std::unique_ptr<StreamContainer> stream_;
std::string view_id_;
+ int embedder_frame_process_id_;
+ int embedder_frame_routing_id_;
+ int embedder_widget_routing_id_;
+
DISALLOW_COPY_AND_ASSIGN(MimeHandlerViewGuest);
};

Powered by Google App Engine
This is Rietveld 408576698