Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3603)

Unified Diff: components/guest_view/browser/guest_view_base.h

Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs (Closed)
Patch Set: Added a comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/browser/guest_view_base.h
diff --git a/components/guest_view/browser/guest_view_base.h b/components/guest_view/browser/guest_view_base.h
index 320a5e4d50b269831aeb861b657a7c3d3f4646df..81f33923958b16bb449674daba6047274480fe78 100644
--- a/components/guest_view/browser/guest_view_base.h
+++ b/components/guest_view/browser/guest_view_base.h
@@ -200,6 +200,10 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
void SetAttachParams(const base::DictionaryValue& params);
void SetOpener(GuestViewBase* opener);
+ // BrowserPluginGuestDelegate implementation.
+ content::RenderWidgetHost* GetOwnerRenderWidgetHost() override;
+ content::SiteInstance* GetOwnerSiteInstance() override;
+
protected:
explicit GuestViewBase(content::WebContents* owner_web_contents);
@@ -208,6 +212,12 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
// BrowserPluginGuestDelegate implementation.
void SetContextMenuPosition(const gfx::Point& position) override;
+ // TODO(ekaramad): If a guest is based on BrowserPlugin and is embedded inside
+ // a cross-process frame, we need to notify the destruction of the frame so
+ // that the clean-up on the browser side is done appropriately. Remove this
+ // methdo when BrowserPlugin is removed (https://crbug.com/535197).
Charlie Reis 2016/11/16 22:25:27 nit: method
EhsanK 2016/11/16 22:47:49 Done.
+ virtual void OnRenderFrameHostDeleted(int process_id, int routing_id);
+
// WebContentsDelegate implementation.
void HandleKeyboardEvent(
content::WebContents* source,

Powered by Google App Engine
This is Rietveld 408576698