Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: content/browser/renderer_host/render_widget_host_input_event_router.cc

Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs (Closed)
Patch Set: Addressing lfg@ and nasko@ comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_input_event_router.cc
diff --git a/content/browser/renderer_host/render_widget_host_input_event_router.cc b/content/browser/renderer_host/render_widget_host_input_event_router.cc
index 3603ae2d83f8e927f3952f95a37ae7d17b8a546e..dbb8460a873a2425faa73a1088995caba1c99dea 100644
--- a/content/browser/renderer_host/render_widget_host_input_event_router.cc
+++ b/content/browser/renderer_host/render_widget_host_input_event_router.cc
@@ -197,7 +197,20 @@ void RenderWidgetHostInputEventRouter::RouteMouseEvent(
// the embedding renderer and then BrowserPluginGuest.
if (target && target->IsRenderWidgetHostViewGuest()) {
ui::LatencyInfo latency_info;
- root_view->ProcessMouseEvent(*event, latency_info);
+ RenderWidgetHostViewBase* embedder =
+ static_cast<RenderWidgetHostViewChildFrame*>(target)
Charlie Reis 2016/11/02 20:47:07 Can we just cast to RenderWidgetHostViewGuest here
EhsanK 2016/11/08 23:10:16 Yes but we are in renderer_host/. Should I add exc
+ ->GetOwnerRenderWidgetHostView();
+ if (embedder != root_view) {
+ // This happens when the view is embedded inside a cross-process frame.
+ gfx::Point embedder_point;
+ if (!root_view->TransformPointToCoordSpaceForView(
+ gfx::Point(event->x, event->y), embedder, &embedder_point)) {
+ return;
+ }
+ event->x = embedder_point.x();
+ event->y = embedder_point.y();
+ }
+ embedder->ProcessMouseEvent(*event, latency_info);
return;
}

Powered by Google App Engine
This is Rietveld 408576698