Allow MimeHandlerViewGuest be embedded inside OOPIFs

components/guest_view/browser/guest_view_manager.cc

Index: components/guest_view/browser/guest_view_manager.cc
diff --git a/components/guest_view/browser/guest_view_manager.cc b/components/guest_view/browser/guest_view_manager.cc
index 1734c762657e9ae169d5d621fc0c84cd8fbe7d26..3e553f3ef28ef444c1f076e0e6df3a350dc3eb4a 100644
--- a/components/guest_view/browser/guest_view_manager.cc
+++ b/components/guest_view/browser/guest_view_manager.cc
@@ -463,8 +463,14 @@ bool GuestViewManager::CanEmbedderAccessInstanceID(
   if (!guest_view)
     return false;
 
+  if (guest_view->IsViewType("mimehandler")) {

[Fady Samuel, 2016/11/08 16:14:23]

drive-by: This is a layering violation. components/guest_view should not know
about mime handler. Instead, could you make a virtual method that
MimeHandlerViewGuest overrides that alters this behavior?

[EhsanK, 2016/11/08 23:10:16]

Done. I added a new method which explicitly asks if the guest can be embedded
inside a cross process frame.

+    // MimeHandlerViewGuests (PDF) may be embedded in a cross origin frame.
+    return embedder_render_process_id ==
+           guest_view->GetEmbedderFrame()->GetProcess()->GetID();
+  }
+
   return embedder_render_process_id ==

[Charlie Reis, 2016/11/02 20:47:06]

To the clarify the comment above, let's add:
// Other than MimeHandlerViewGuest, all other guests are only permitted to run
in the main frame.

[EhsanK, 2016/11/08 23:10:16]

Thanks. I also changed "cross origin" to "cross process" in comment above since
we actually pay attention to the process ID rather than the origin.

-      guest_view->owner_web_contents()->GetRenderProcessHost()->GetID();
+         guest_view->owner_web_contents()->GetRenderProcessHost()->GetID();
 }
 
 GuestViewManager::ElementInstanceKey::ElementInstanceKey()