Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2192)

Unified Diff: content/public/browser/browser_plugin_guest_delegate.h

Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/browser_plugin_guest_delegate.h
diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h
index 0f805651ba8bafe5240a5fbe5772e06d43a75081..c6f3bc1cea88c4ddbefb762ede261dde7ed80508 100644
--- a/content/public/browser/browser_plugin_guest_delegate.h
+++ b/content/public/browser/browser_plugin_guest_delegate.h
@@ -97,6 +97,11 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
// a BrowserPlugin even when we are using cross process frames for guests. It
// should be removed after resolving https://crbug.com/642826).
virtual bool CanUseCrossProcessFrames();
+
+ // Returns the RenderFrameHost corresponding to the RenderFrame embedding the
+ // BrowserPlugin. This is the main frame for the owner of the guests, unless,
nasko 2016/10/27 21:03:40 Based on the implementation, it returns the main f
EhsanK 2016/10/27 22:06:48 As far as I can tell, only MimeHandlerViewGuest ca
nasko 2016/11/09 01:13:07 I haven't had a chance to try it manually, but oth
EhsanK 2016/11/15 19:54:22 You are right but I have not been able to do it in
+ // the guest is embedded inside a cross origin frame.
nasko 2016/10/27 21:03:40 Can we have cross-origin frames in apps?
EhsanK 2016/10/27 22:06:48 I don't think we can use <iframe>'s in apps at all
nasko 2016/11/09 01:13:07 AFAIK, you can use <iframes> to local files in the
EhsanK 2016/11/15 19:54:22 You are correct. I could do this using web_accessi
Charlie Reis 2016/11/15 23:45:32 We don't need to support the more general case in
+ virtual RenderFrameHost* GetEmbedderFrame();
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698