Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2023)

Unified Diff: components/guest_view/browser/guest_view_base.cc

Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/browser/guest_view_base.cc
diff --git a/components/guest_view/browser/guest_view_base.cc b/components/guest_view/browser/guest_view_base.cc
index e2ffccee70d4728e19726a3b7aea8f4c93c49aaa..edcbd2f0ced6bc447893f8cbf4bce994a45a3324 100644
--- a/components/guest_view/browser/guest_view_base.cc
+++ b/components/guest_view/browser/guest_view_base.cc
@@ -20,6 +20,7 @@
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/render_widget_host.h"
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/page_zoom.h"
@@ -416,9 +417,9 @@ void GuestViewBase::DidAttach(int guest_proxy_routing_id) {
DidAttachToEmbedder();
// Inform the associated GuestViewContainer that the contentWindow is ready.
- embedder_web_contents()->Send(new GuestViewMsg_GuestAttached(
- element_instance_id_,
- guest_proxy_routing_id));
+ GetEmbedderFrame()->GetView()->GetRenderWidgetHost()->Send(
nasko 2016/10/27 21:03:40 Before this IPC was sent through the main frame. N
EhsanK 2016/10/27 22:06:48 As I understand, WebContentsImpl::Send will send i
nasko 2016/11/09 01:13:07 They all send through the same IPC channel. What m
EhsanK 2016/11/15 19:54:22 Acknowledged.
+ new GuestViewMsg_GuestAttached(element_instance_id_,
+ guest_proxy_routing_id));
SendQueuedEvents();
}

Powered by Google App Engine
This is Rietveld 408576698