Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: extensions/browser/guest_view/extensions_guest_view_message_filter.cc

Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs (Closed)
Patch Set: Rebase and nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extensions_guest_view_message_filter.cc
diff --git a/extensions/browser/guest_view/extensions_guest_view_message_filter.cc b/extensions/browser/guest_view/extensions_guest_view_message_filter.cc
index 9dea442edf213b69d205ac770f3f5194607f7add..781997c64feb62fc8f93d97dd528153fe2cc731c 100644
--- a/extensions/browser/guest_view/extensions_guest_view_message_filter.cc
+++ b/extensions/browser/guest_view/extensions_guest_view_message_filter.cc
@@ -169,15 +169,16 @@ void ExtensionsGuestViewMessageFilter::MimeHandlerViewGuestCreatedCallback(
if (!rfh)
return;
+ guest_view->SetEmbedderFrame(embedder_render_process_id,
EhsanK 2016/10/20 21:42:38 This happens before attach which was used previous
+ embedder_render_frame_id);
+
base::DictionaryValue attach_params;
attach_params.SetInteger(guest_view::kElementWidth, element_size.width());
attach_params.SetInteger(guest_view::kElementHeight, element_size.height());
auto* manager = GuestViewManager::FromBrowserContext(browser_context_);
CHECK(manager);
- manager->AttachGuest(embedder_render_process_id,
- element_instance_id,
- guest_instance_id,
- attach_params);
+ manager->AttachGuest(embedder_render_process_id, element_instance_id,
+ guest_instance_id, attach_params);
rfh->Send(
new ExtensionsGuestViewMsg_CreateMimeHandlerViewGuestACK(

Powered by Google App Engine
This is Rietveld 408576698