Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2209)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs (Closed)
Patch Set: Rebase and nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index b556e1cdec81a2b1e161f32525d3743b2aa1351a..04ccb0dff9ad5d9fbf717a8a223eab9829ae4724 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -287,6 +287,13 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
// need to also be resolved.
virtual bool IsRenderWidgetHostViewChildFrame();
+ // TODO(ekaramad): This is used for input event routing when the target of
+ // events is a RenderWidgetHostViewGuest which is embeded in an OOPIF (the
+ // only example right now is MimeHandlerViewGuest). Same as above, this
+ // method should be removed when either direct routing is supported for
+ // RWHVG or RWHVG is removed entirely (https://crbug.com/533069).
+ virtual RenderWidgetHostViewBase* GetOuterView();
lfg 2016/10/20 22:50:49 This doesn't belong here and we shouldn't need it.
EhsanK 2016/10/25 19:30:50 Agreed is we can include RWHVG inside RWHIER. ke
+
//----------------------------------------------------------------------------
// The following methods are related to IME.
// TODO(ekaramad): Most of the IME methods should not stay virtual after IME

Powered by Google App Engine
This is Rietveld 408576698