components/guest_view/browser/guest_view_manager.h - Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_manager.h

Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs (Closed)

Patch Set: Rebase and nits Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/guest_view/browser/guest_view_manager.h

diff --git a/components/guest_view/browser/guest_view_manager.h b/components/guest_view/browser/guest_view_manager.h

index 033e2a2cd1bc044412f85871708345a1728f757e..401c617614ac6274a3d991abb58ca51dc69a46a7 100644

--- a/components/guest_view/browser/guest_view_manager.h

+++ b/components/guest_view/browser/guest_view_manager.h

@@ -62,9 +62,9 @@ class GuestViewManager : public content::BrowserPluginGuestManager,

int guest_instance_id,

int embedder_render_process_id);

- // Associates the Browser Plugin with |element_instance_id| to a

- // guest that has ID of |guest_instance_id| and sets initialization

- // parameters, |params| for it.

+ // Associates the Browser Plugin with |element_instance_id| to a guest that

lfg 2016/10/20 22:50:49 No need to change this.

EhsanK 2016/10/25 19:30:50 Acknowledged.

+ // has ID of |guest_instance_id| and sets initialization parameters, |params|

+ // for it.

void AttachGuest(int embedder_process_id,

int element_instance_id,

int guest_instance_id,