Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: components/guest_view/browser/guest_view_message_filter.cc

Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs (Closed)
Patch Set: Setting embedder frame id when the MimeHandlerViewGuest is created. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/browser/guest_view_message_filter.cc
diff --git a/components/guest_view/browser/guest_view_message_filter.cc b/components/guest_view/browser/guest_view_message_filter.cc
index bb17ea69d4abe3c977883d56dfe2b5e8474a5e13..fe81715ba3c8525651751a377da7c141815884ba 100644
--- a/components/guest_view/browser/guest_view_message_filter.cc
+++ b/components/guest_view/browser/guest_view_message_filter.cc
@@ -108,10 +108,8 @@ void GuestViewMessageFilter::OnAttachGuest(
if (!manager)
return;
- manager->AttachGuest(render_process_id_,
- element_instance_id,
- guest_instance_id,
- params);
+ manager->AttachGuest(render_process_id_, element_instance_id,
kenrb 2016/10/20 16:12:05 It isn't worth touching this file for what is now
EhsanK 2016/10/20 21:41:17 Yes. I was on my changelist in earlier patches and
+ guest_instance_id, params);
}
void GuestViewMessageFilter::OnAttachToEmbedderFrame(

Powered by Google App Engine
This is Rietveld 408576698