Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: components/guest_view/renderer/guest_view_request.cc

Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs (Closed)
Patch Set: Added a NOTREACHED Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/renderer/guest_view_request.cc
diff --git a/components/guest_view/renderer/guest_view_request.cc b/components/guest_view/renderer/guest_view_request.cc
index 1d26c3f4462bab8457123d1ec9e911feff15fd7f..9c81c8811ad78a9397697d5e154568ec818b6ecf 100644
--- a/components/guest_view/renderer/guest_view_request.cc
+++ b/components/guest_view/renderer/guest_view_request.cc
@@ -62,17 +62,17 @@ GuestViewAttachRequest::~GuestViewAttachRequest() {
}
void GuestViewAttachRequest::PerformRequest() {
- if (!container()->render_frame())
+ content::RenderFrame* render_frame = container()->render_frame();
+ if (!render_frame)
return;
// Step 1, send the attach params to guest_view/.
- container()->render_frame()->Send(
- new GuestViewHostMsg_AttachGuest(container()->element_instance_id(),
- guest_instance_id_,
- *params_));
+ render_frame->Send(new GuestViewHostMsg_AttachGuest(
+ container()->element_instance_id(), guest_instance_id_,
+ render_frame->GetRoutingID(), *params_));
// Step 2, attach plugin through content/.
- container()->render_frame()->AttachGuest(container()->element_instance_id());
+ render_frame->AttachGuest(container()->element_instance_id());
}
void GuestViewAttachRequest::HandleResponse(const IPC::Message& message) {

Powered by Google App Engine
This is Rietveld 408576698