Allow MimeHandlerViewGuest be embedded inside OOPIFs

content/browser/renderer_host/render_widget_host_input_event_router.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_input_event_router.h"
 
 #include <vector>
 
 #include "base/metrics/histogram_macros.h"
 
 #include "cc/quads/surface_draw_quad.h"
 #include "cc/surfaces/surface_id_allocator.h"
 #include "cc/surfaces/surface_manager.h"
 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
+#include "content/browser/frame_host/render_widget_host_view_guest.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/common/frame_messages.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "ui/events/blink/web_input_event_traits.h"
 
 namespace {
 
 void TransformEventTouchPositions(blink::WebTouchEvent* event,
                                   const gfx::Vector2d& delta) {
@@ skipping 165 matching lines @@
   } else {
     target = FindEventTarget(root_view, gfx::Point(event->x, event->y),
                              &transformed_point);
   }
 
   // RenderWidgetHostViewGuest does not properly handle direct routing of mouse
   // events, so they have to go by the double-hop forwarding path through
   // the embedding renderer and then BrowserPluginGuest.
   if (target && target->IsRenderWidgetHostViewGuest()) {
     ui::LatencyInfo latency_info;
-    root_view->ProcessMouseEvent(*event, latency_info);
+    RenderWidgetHostViewBase* owner_view =
+        static_cast<RenderWidgetHostViewGuest*>(target)
+            ->GetOwnerRenderWidgetHostView();
+    while (owner_view->IsRenderWidgetHostViewGuest()) {

[EhsanK, 2016/11/15 19:54:22]

We need to send all the input events to the embedder of the
RenderWidgetHostViewGuest but apparently that cannot be a
RenderWidgetHostViewGuest it self or the routing fails.

wjmaclean@: Does this seem OK to you. Without adding this I could not type into
a PDF inside a <webview> which was based on BrowserPlugin.

[wjmaclean, 2016/11/15 20:02:39]

The idea of finding the first non-RWHVG owner seems ok, given the reasons why we
were going to the root_view originally ... that cod certainly never was intended
to handle the case of multipally-embedded PDFs ... lgtm.

[EhsanK, 2016/11/16 21:27:31]

Thanks. I added a short comment just to be more clear on this.

+      owner_view = static_cast<RenderWidgetHostViewGuest*>(owner_view)
+                       ->GetOwnerRenderWidgetHostView();
+    }
+
+    if (owner_view != root_view) {
+      // This happens when the view is embedded inside a cross-process frame.
+      gfx::Point owner_point;
+      if (!root_view->TransformPointToCoordSpaceForView(
+              gfx::Point(event->x, event->y), owner_view, &owner_point)) {
+        return;
+      }
+      event->x = owner_point.x();
+      event->y = owner_point.y();
+    }
+    owner_view->ProcessMouseEvent(*event, latency_info);
     return;
   }
 
   if (event->type == blink::WebInputEvent::MouseDown)
     mouse_capture_target_.target = target;
 
   if (!target)
     return;
 
   // SendMouseEnterOrLeaveEvents is called with the original event
@@ skipping 537 matching lines @@
   if (!touchpad_gesture_target_.target)
     return;
 
   // TODO(mohsen): Add tests to check event location.
   event->x += touchpad_gesture_target_.delta.x();
   event->y += touchpad_gesture_target_.delta.y();
   touchpad_gesture_target_.target->ProcessGestureEvent(*event, latency);
 }
 
 }  // namespace content