Allow MimeHandlerViewGuest be embedded inside OOPIFs

content/browser/frame_host/render_widget_host_view_child_frame.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
 #define CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 173 matching lines @@
   }
 
   // Returns the current surface scale factor.
   float current_surface_scale_factor() { return current_surface_scale_factor_; }
 
   // Returns the view into which this view is directly embedded. This can
   // return nullptr when this view's associated child frame is not connected
   // to the frame tree.
   RenderWidgetHostViewBase* GetParentView();
 
+  // TODO(ekaramad): This is used for input event routing when the target of
+  // events is a RenderWidgetHostViewGuest which is embeded in an OOPIF (the

[Charlie Reis, 2016/11/02 20:47:06]

nit: embedded

[EhsanK, 2016/11/08 23:10:16]

Done.

+  // only example right now is MimeHandlerViewGuest). Same as above, this
+  // method should be removed when either direct routing is supported for RWHVG
+  // (and made a private member of RWHVG again) or RWHVG is removed entirely
+  // (https://crbug.com/533069).
+  virtual RenderWidgetHostViewBase* GetOwnerRenderWidgetHostView() const;

[Charlie Reis, 2016/11/02 20:47:06]

Why does this need to be here, if it's implemented as a NOTREACHED and only
callable on the subclass (RWHVG)?  Would it be easier to cast to RWHVG at the
only callsite (RenderWidgetHostInputEventRouter::RouteMouseEvent) and leave it
out of this class?

[EhsanK, 2016/11/08 23:10:16]

Yes, it would definitely be easier (lfg@ also suggested this earlier). I avoided
doing this originally because this is a layering violation (RWHVG lives inside
frame_host/ while RWHIER is inside renderer_host).

But as I understand this approached is being favored over adding the method to
RWHVCF esp. given that we already violate this for RWHVCF (there is also a
comment about it inside the DEPS file for renderer_host/).

I made the change and modified the DEPS file.

+
   void RegisterFrameSinkId();
   void UnregisterFrameSinkId();
 
  protected:
   friend class RenderWidgetHostView;
   friend class RenderWidgetHostViewChildFrameTest;
   friend class RenderWidgetHostViewGuestSurfaceTest;
 
   explicit RenderWidgetHostViewChildFrame(RenderWidgetHost* widget);
   void Init();
@@ skipping 50 matching lines @@
   // The surface client ID of the parent RenderWidgetHostView.  0 if none.
   cc::FrameSinkId parent_frame_sink_id_;
 
   base::WeakPtrFactory<RenderWidgetHostViewChildFrame> weak_factory_;
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewChildFrame);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_