Allow MimeHandlerViewGuest be embedded inside OOPIFs

components/guest_view/browser/guest_view_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/guest_view/browser/guest_view_manager.h"
 
 #include <tuple>
 #include <utility>
 
 #include "base/macros.h"
@@ skipping 445 matching lines @@
   // We might get some late arriving messages at tear down. Let's let the
   // embedder tear down in peace.
   auto it = guest_web_contents_by_instance_id_.find(guest_instance_id);
   if (it == guest_web_contents_by_instance_id_.end())
     return true;
 
   auto* guest_view = GuestViewBase::FromWebContents(it->second);
   if (!guest_view)
     return false;
 
+  if (guest_view->IsViewType("mimehandler")) {

[Fady Samuel, 2016/11/08 16:14:23]

drive-by: This is a layering violation. components/guest_view should not know
about mime handler. Instead, could you make a virtual method that
MimeHandlerViewGuest overrides that alters this behavior?

[EhsanK, 2016/11/08 23:10:16]

Done. I added a new method which explicitly asks if the guest can be embedded
inside a cross process frame.

+    // MimeHandlerViewGuests (PDF) may be embedded in a cross origin frame.
+    return embedder_render_process_id ==
+           guest_view->GetEmbedderFrame()->GetProcess()->GetID();
+  }
+
   return embedder_render_process_id ==

[Charlie Reis, 2016/11/02 20:47:06]

To the clarify the comment above, let's add:
// Other than MimeHandlerViewGuest, all other guests are only permitted to run
in the main frame.

[EhsanK, 2016/11/08 23:10:16]

Thanks. I also changed "cross origin" to "cross process" in comment above since
we actually pay attention to the process ID rather than the origin.

-      guest_view->owner_web_contents()->GetRenderProcessHost()->GetID();
+         guest_view->owner_web_contents()->GetRenderProcessHost()->GetID();
 }
 
 GuestViewManager::ElementInstanceKey::ElementInstanceKey()
     : embedder_process_id(content::ChildProcessHost::kInvalidUniqueID),
       element_instance_id(content::ChildProcessHost::kInvalidUniqueID) {
 }
 
 GuestViewManager::ElementInstanceKey::ElementInstanceKey(
     int embedder_process_id,
     int element_instance_id)
@@ skipping 17 matching lines @@
     const GuestViewCreateFunction& create_function,
     const GuestViewCleanUpFunction& cleanup_function)
     : create_function(create_function), cleanup_function(cleanup_function) {}
 
 GuestViewManager::GuestViewData::GuestViewData(const GuestViewData& other) =
     default;
 
 GuestViewManager::GuestViewData::~GuestViewData() {}
 
 }  // namespace guest_view