Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2417693002: Allow MimeHandlerViewGuest be embedded inside OOPIFs (Closed)
Patch Set: Added a NOTREACHED Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 // entirely, which comes first. 280 // entirely, which comes first.
281 virtual bool IsRenderWidgetHostViewGuest(); 281 virtual bool IsRenderWidgetHostViewGuest();
282 282
283 // Subclass identifier for RenderWidgetHostViewChildFrames. This is useful 283 // Subclass identifier for RenderWidgetHostViewChildFrames. This is useful
284 // to be able to know if this RWHV is embedded within another RWHV. If 284 // to be able to know if this RWHV is embedded within another RWHV. If
285 // other kinds of embeddable RWHVs are created, this should be renamed to 285 // other kinds of embeddable RWHVs are created, this should be renamed to
286 // a more generic term -- in which case, static casts to RWHVChildFrame will 286 // a more generic term -- in which case, static casts to RWHVChildFrame will
287 // need to also be resolved. 287 // need to also be resolved.
288 virtual bool IsRenderWidgetHostViewChildFrame(); 288 virtual bool IsRenderWidgetHostViewChildFrame();
289 289
290 // TODO(ekaramad): This is used for input event routing when the target of
291 // events is a RenderWidgetHostViewGuest which is embeded in an OOPIF (the
292 // only example right now is MimeHandlerViewGuest). Same as above, this
293 // method should be removed when either direct routing is supported for
294 // RWHVG or RWHVG is removed entirely.
295 virtual RenderWidgetHostViewBase* GetEmbedderView();
Charlie Reis 2016/10/18 22:52:20 Should we be using a different term here, like "ou
EhsanK 2016/10/20 21:41:17 I think outer is better in that case. But technica
296
290 //---------------------------------------------------------------------------- 297 //----------------------------------------------------------------------------
291 // The following methods are related to IME. 298 // The following methods are related to IME.
292 // TODO(ekaramad): Most of the IME methods should not stay virtual after IME 299 // TODO(ekaramad): Most of the IME methods should not stay virtual after IME
293 // is implemented for OOPIF. After fixing IME, mark the corresponding methods 300 // is implemented for OOPIF. After fixing IME, mark the corresponding methods
294 // non-virtual (https://crbug.com/578168). 301 // non-virtual (https://crbug.com/578168).
295 302
296 // Updates the state of the input method attached to the view. 303 // Updates the state of the input method attached to the view.
297 virtual void TextInputStateChanged(const TextInputState& text_input_state); 304 virtual void TextInputStateChanged(const TextInputState& text_input_state);
298 305
299 // Cancel the ongoing composition of the input method attached to the view. 306 // Cancel the ongoing composition of the input method attached to the view.
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_; 506 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
500 507
501 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_; 508 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
502 509
503 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase); 510 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
504 }; 511 };
505 512
506 } // namespace content 513 } // namespace content
507 514
508 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 515 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698