Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2417673003: Revert changes made to ImageResource memory accounting at crrev.com/2337733002 (Closed)

Created:
4 years, 2 months ago by ssid
Modified:
4 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert changes made to ImageResource memory accounting at crrev.com/2337733002 The actual fix for image resources being misaccounted is done in crrev.com/2393113002. The m_image should not be counted for each resource since it is shared. BUG=654715 Committed: https://crrev.com/df8812aed3208ee6bc40161df33e2b4b9be5521a Cr-Commit-Position: refs/heads/master@{#424960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResource.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/SharedBuffer.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ssid
ptal, thanks.
4 years, 2 months ago (2016-10-13 03:11:15 UTC) #4
haraken
LGTM
4 years, 2 months ago (2016-10-13 03:48:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417673003/1
4 years, 2 months ago (2016-10-13 04:57:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 05:03:09 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 05:05:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df8812aed3208ee6bc40161df33e2b4b9be5521a
Cr-Commit-Position: refs/heads/master@{#424960}

Powered by Google App Engine
This is Rietveld 408576698