Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2417673002: [Android] Allow __NR_sysinfo and __NR_clock_getres under seccomp. (Closed)

Created:
4 years, 2 months ago by Robert Sesek
Modified:
4 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Allow __NR_sysinfo and __NR_clock_getres under seccomp. sysinfo() is allowed unconditionally, while clock_getres() is restricted to the set of clk_ids that clock_gettime() is. BUG=655277, 655299 R=rickyz@chromium.org Committed: https://crrev.com/6cc408a029eb5fc6d9c10f556df6c717fcaabb9a Cr-Commit-Position: refs/heads/master@{#424911}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc View 3 chunks +7 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Robert Sesek
4 years, 2 months ago (2016-10-12 21:48:58 UTC) #1
rickyz (no longer on Chrome)
lgtm https://codereview.chromium.org/2417673002/diff/1/content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc File content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc (right): https://codereview.chromium.org/2417673002/diff/1/content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc#newcode124 content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc:124: override_and_allow = true; This doesn't have anything to ...
4 years, 2 months ago (2016-10-12 22:24:50 UTC) #2
Robert Sesek
Thanks! https://codereview.chromium.org/2417673002/diff/1/content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc File content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc (right): https://codereview.chromium.org/2417673002/diff/1/content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc#newcode124 content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc:124: override_and_allow = true; On 2016/10/12 22:24:50, rickyz wrote: ...
4 years, 2 months ago (2016-10-12 23:24:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417673002/1
4 years, 2 months ago (2016-10-12 23:25:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 23:52:35 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 23:55:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cc408a029eb5fc6d9c10f556df6c717fcaabb9a
Cr-Commit-Position: refs/heads/master@{#424911}

Powered by Google App Engine
This is Rietveld 408576698