Expose RTT and throughput estimates from Cronet

net/nqe/network_quality.h

Index: net/nqe/network_quality.h
diff --git a/net/nqe/network_quality.h b/net/nqe/network_quality.h
index 457c71e88878ec8f818a9578976730cf469d57f0..32eacb57c8a8aa9060b356991421ddaaa1073178 100644
--- a/net/nqe/network_quality.h
+++ b/net/nqe/network_quality.h
@@ -16,14 +16,26 @@ namespace net {
 namespace nqe {
 namespace internal {
 
+// RTT and throughput values are set to |INVALID_RTT_THROUGHPUT_VALUE| if a
+// valid value is unavailable.
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.net
+enum RttThroughputValues {
+  // Invalid value.
+  INVALID_RTT_THROUGHPUT_VALUE = -1,
+};
+
 // Returns the RTT value to be used when the valid RTT is unavailable. Readers
 // should discard RTT if it is set to the value returned by |InvalidRTT()|.
+// TODO(tbansal): Remove this method, and replace all calls by
+// |INVALID_RTT_THROUGHPUT_VALUE|.
 NET_EXPORT_PRIVATE base::TimeDelta InvalidRTT();
 
 // Throughput is set to |kInvalidThroughput| if a valid value is
 // unavailable. Readers should discard throughput value if it is set to
 // |kInvalidThroughput|.
-const int32_t kInvalidThroughput = 0;
+// TODO(tbansal): Remove this variable, and replace all calls by
+// |INVALID_RTT_THROUGHPUT_VALUE|.
+const int32_t kInvalidThroughput = INVALID_RTT_THROUGHPUT_VALUE;

[RyanSturm, 2016/10/14 21:21:32]

Why was this exposed in the header as a const? Seems like this should be an
extern const or a macro. If you're removing it later that this is fine to leave
as is.

[tbansal1, 2016/10/14 21:50:29]

Yup, this is going to be removed soon.

[RyanSturm, 2016/10/14 22:19:13]

Acknowledged.

 
 // NetworkQuality is used to cache the quality of a network connection.
 class NET_EXPORT_PRIVATE NetworkQuality {