Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 2417643007: Expose RTT and throughput estimates from Cronet (Closed)
Patch Set: ps Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
index e386b670818795ac45ad4087aafae7d93410e0ff..7228f6122462fbe424ca6189678c880fef0d82fa 100644
--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
@@ -780,6 +780,12 @@ public abstract class CronetEngine {
}
}
+ /**
+ * RTT and throughput estimates are set to {@link INVALID_RTT_THROUGHPUT} if
+ * a valid value is unavailable,
mgersh 2016/10/17 16:53:09 nit: comma should be period
tbansal1 2016/10/17 19:20:57 Done.
+ */
+ public static final int INVALID_RTT_THROUGHPUT = -1;
+
private static final String TAG = "UrlRequestFactory";
private static final String CRONET_URL_REQUEST_CONTEXT =
"org.chromium.net.impl.CronetUrlRequestContext";
@@ -993,6 +999,33 @@ public abstract class CronetEngine {
public abstract int getEffectiveConnectionType();
/**
+ * Returns the HTTP RTT estimate (in milliseconds) computed by the network
+ * quality estimator. Set to {@link INVALID_RTT_THROUGHPUT} if a valid value
mgersh 2016/10/17 16:53:09 This javadoc and the others could mention that you
tbansal1 2016/10/17 19:20:57 Done.
+ * is unavailable.
+ * @hide as it's a prototype.
+ * @return Estimate of the HTTP RTT in milliseconds.
+ */
+ public abstract int getHttpRttMsec();
mgersh 2016/10/17 16:53:09 Elsewhere in Cronet we use Ms, not Msec. Let's cha
tbansal1 2016/10/17 19:20:57 Done.
+
+ /**
+ * Returns the transport RTT estimate (in milliseconds) computed by the
+ * network quality estimator. Set to {@link INVALID_RTT_THROUGHPUT} if a
+ * valid value is unavailable.
+ * @hide as it's a prototype.
+ * @return Estimate of the transport RTT in milliseconds.
+ */
+ public abstract int getTransportRttMsec();
mgersh 2016/10/17 16:53:09 same as above: Msec -> Ms
tbansal1 2016/10/17 19:20:57 Done.
+
+ /**
+ * Returns the downstream throughput estimate (in kilobits per second)
+ * computed by the network quality estimator. Set to
+ * {@link INVALID_RTT_THROUGHPUT} if a valid value is unavailable.
+ * @hide as it's a prototype.
+ * @return Estimate of the downstream throughput in kilobits per second.
+ */
+ public abstract int getDownstreamThroughputKbps();
+
+ /**
* Configures the network quality estimator for testing. This must be called
* before round trip time and throughput listeners are added, and after the
* network quality estimator has been enabled.

Powered by Google App Engine
This is Rietveld 408576698