Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2417643004: Explicitly check for lazy parser when dealing with parser cache (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Explicitly check for lazy parser when dealing with parser cache BUG=v8:5501 Committed: https://crrev.com/9284459748877a5c842936a177d17a72690c5d40 Cr-Commit-Position: refs/heads/master@{#40269}

Patch Set 1 #

Patch Set 2 : Simplify dealing with parser cache #

Patch Set 3 : Reset compile options to kNoCompileOptions if the cache is invalid #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -39 lines) Patch
M src/background-parsing-task.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler.cc View 1 chunk +2 lines, -24 lines 0 comments Download
M src/parsing/parse-info.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/parsing/parse-info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parsing/parser.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-13 12:57:50 UTC) #2
marja
lgtm
4 years, 2 months ago (2016-10-13 13:02:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417643004/40001
4 years, 2 months ago (2016-10-13 13:04:36 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 14:01:48 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 14:02:13 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9284459748877a5c842936a177d17a72690c5d40
Cr-Commit-Position: refs/heads/master@{#40269}

Powered by Google App Engine
This is Rietveld 408576698