Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2417643003: Turn AllowsLazyParsingWithoutUnresolvedVariables into a whitelist stopping at the outer parsed cont… (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn AllowsLazyParsingWithoutUnresolvedVariables into a whitelist stopping at the outer parsed context. Any context outer to what we're parsing already has proper context allocation, so we don't need to check those scopes. BUG=v8:5501 Committed: https://crrev.com/1bb9fb34d78fe697cf1497e2db99834dc8963ec8 Cr-Commit-Position: refs/heads/master@{#40256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M src/ast/scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast/scopes.cc View 1 chunk +23 lines, -8 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/preparser.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-13 11:31:48 UTC) #2
marja
lgtm
4 years, 2 months ago (2016-10-13 11:36:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417643003/1
4 years, 2 months ago (2016-10-13 11:56:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 12:21:49 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 12:22:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bb9fb34d78fe697cf1497e2db99834dc8963ec8
Cr-Commit-Position: refs/heads/master@{#40256}

Powered by Google App Engine
This is Rietveld 408576698