Chromium Code Reviews

Issue 2417633002: Cleanup nits from merge CL (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+33 lines, -52 lines)
M fpdfsdk/cpdfsdk_formfillenvironment.h View 5 chunks +23 lines, -37 lines 1 comment
M fpdfsdk/cpdfsdk_formfillenvironment.cpp View 6 chunks +10 lines, -15 lines 0 comments

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL. https://codereview.chromium.org/2417633002/diff/1/fpdfsdk/cpdfsdk_formfillenvironment.h File fpdfsdk/cpdfsdk_formfillenvironment.h (right): https://codereview.chromium.org/2417633002/diff/1/fpdfsdk/cpdfsdk_formfillenvironment.h#newcode104 fpdfsdk/cpdfsdk_formfillenvironment.h:104: return m_pUnderlyingDoc; This just returned the same thing ...
4 years, 2 months ago (2016-10-12 19:44:13 UTC) #2
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-12 20:26:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417633002/1
4 years, 2 months ago (2016-10-12 20:27:54 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 20:41:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6c659ab22988716c0f578460a2048663ab93...

Powered by Google App Engine