Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2417623002: Fix a FindBugs warning in JsonSanitizer.java (Closed)

Created:
4 years, 2 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, agrieve+watch_chromium.org, ghost stip (do not use)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a FindBugs warning in JsonSanitizer.java It appeared when trying to switch to Android N sdk: SF_SWITCH_NO_DEFAULT: Switch statement found where default case is missing In class org.chromium.components.safejson.JsonSanitizer In method org.chromium.components.safejson.JsonSanitizer.sanitize(String) At JsonSanitizer.java:[lines 54-100] BUG=623989 Committed: https://crrev.com/e0a9c9a7654cc74ece6b7255560d8ce37bf3ef36 Cr-Commit-Position: refs/heads/master@{#424859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/safe_json/android/java/src/org/chromium/components/safejson/JsonSanitizer.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
agrieve
💠
4 years, 2 months ago (2016-10-12 19:14:17 UTC) #2
Robert Sesek
LGTM
4 years, 2 months ago (2016-10-12 19:15:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417623002/1
4 years, 2 months ago (2016-10-12 20:34:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 21:24:05 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 21:29:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0a9c9a7654cc74ece6b7255560d8ce37bf3ef36
Cr-Commit-Position: refs/heads/master@{#424859}

Powered by Google App Engine
This is Rietveld 408576698