Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2417603002: Several fixes to screen capturer mac. (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Several fixes to screen_capturer_mac. Make sure that the appropriate run loop source gets added/removed. More clean up to remove unnecessary functions and suppress deprecated declaration warnings. BUG=webrtc:6029 Committed: https://crrev.com/73fdc317b21afc4c1468eb11202a8cf09eddb000 Cr-Commit-Position: refs/heads/master@{#14615}

Patch Set 1 #

Patch Set 2 : nits. #

Patch Set 3 : nits #

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -66 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 1 2 3 8 chunks +43 lines, -66 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
erikchen
sergeyu: Please review.
4 years, 2 months ago (2016-10-12 18:40:13 UTC) #3
Sergey Ulanov
lgtm
4 years, 2 months ago (2016-10-12 18:50:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2417603002/60001
4 years, 2 months ago (2016-10-12 18:53:52 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-12 19:24:13 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 19:24:31 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/73fdc317b21afc4c1468eb11202a8cf09eddb000
Cr-Commit-Position: refs/heads/master@{#14615}

Powered by Google App Engine
This is Rietveld 408576698