Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2417533002: [Sensors] Read-only access to the sensors shared buffer from Blink (Closed)

Created:
4 years, 2 months ago by Mikhail
Modified:
4 years, 2 months ago
Reviewers:
shalamov, timvolodine
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Read-only access to the sensors shared buffer from Blink Provide read-only access to the sensors shared buffer for the Blink-side clients (i.e. JS sensor instances). BUG=606766 Committed: https://crrev.com/47234d95ab0dab229fa8c108b80bdb0ac63ed151 Cr-Commit-Position: refs/heads/master@{#424741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M device/generic_sensor/platform_sensor_provider_base.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
Mikhail
PTAL
4 years, 2 months ago (2016-10-12 12:22:07 UTC) #8
shalamov
lgtm
4 years, 2 months ago (2016-10-12 12:49:40 UTC) #9
timvolodine
lgtm
4 years, 2 months ago (2016-10-12 14:53:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417533002/20001
4 years, 2 months ago (2016-10-12 15:22:15 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-12 15:28:12 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 15:30:27 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47234d95ab0dab229fa8c108b80bdb0ac63ed151
Cr-Commit-Position: refs/heads/master@{#424741}

Powered by Google App Engine
This is Rietveld 408576698