Add PRESUBMIT to disallow new usage of FOR_EACH_OBSERVER.

Add PRESUBMIT to disallow new usage of FOR_EACH_OBSERVER.

BUG=655021
Committed: https://crrev.com/8f0694bae6c808bb107c1e1f4e72c4cc88685e2f
Cr-Commit-Position: refs/heads/master@{#424752}

[dcheng, 2016-10-12 06:23:23]

dcheng@chromium.org changed reviewers:
+ jochen@chromium.org

[loyso (OOO), 2016-10-12 06:27:23]

loyso@chromium.org changed reviewers:
+ loyso@chromium.org

[loyso (OOO), 2016-10-12 06:27:24]

https://codereview.chromium.org/2417513002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2417513002/diff/1/PRESUBMIT.py#newcode314
PRESUBMIT.py:314: '        for (auto& observer : observers) {
observer->Observe(); }',
observer.Observe();

[dcheng, 2016-10-12 06:36:12]

https://codereview.chromium.org/2417513002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2417513002/diff/1/PRESUBMIT.py#newcode314
PRESUBMIT.py:314: '        for (auto& observer : observers) {
observer->Observe(); }',
On 2016/10/12 06:27:24, loyso wrote:
> observer.Observe();

Oops done.

[jochen (gone - plz use gerrit), 2016-10-12 09:35:38]

lgtm

[dcheng, 2016-10-12 15:49:01]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:49:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:58:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 16:02:46]

Description was changed from

==========
Add PRESUBMIT to disallow new usage of FOR_EACH_OBSERVER.

BUG=655021
==========

to

==========
Add PRESUBMIT to disallow new usage of FOR_EACH_OBSERVER.

BUG=655021

Committed: https://crrev.com/8f0694bae6c808bb107c1e1f4e72c4cc88685e2f
Cr-Commit-Position: refs/heads/master@{#424752}
==========

[commit-bot: I haz the power, 2016-10-12 16:02:47]

Patchset 2 (id:??) landed as
https://crrev.com/8f0694bae6c808bb107c1e1f4e72c4cc88685e2f
Cr-Commit-Position: refs/heads/master@{#424752}