Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: ui/app_list/views/app_list_main_view.cc

Issue 24175004: Remove dependency on ui::ScaleFactor from ui/gfx (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename methods and vars to make image_scale more clear Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/views/app_list_main_view.cc
diff --git a/ui/app_list/views/app_list_main_view.cc b/ui/app_list/views/app_list_main_view.cc
index 7dc19ffcb6cb9798868d54dd0f176cb70ad88026..f2fc46b4625100f9f3be85593c0f2c0ab149ae45 100644
--- a/ui/app_list/views/app_list_main_view.cc
+++ b/ui/app_list/views/app_list_main_view.cc
@@ -43,13 +43,13 @@ class AppListMainView::IconLoader : public AppListItemModelObserver {
public:
IconLoader(AppListMainView* owner,
AppListItemModel* item,
- ui::ScaleFactor scale_factor)
+ float scale)
: owner_(owner),
item_(item) {
item_->AddObserver(this);
// Triggers icon loading for given |scale_factor|.
- item_->icon().GetRepresentation(scale_factor);
+ item_->icon().GetRepresentation(scale);
}
virtual ~IconLoader() {
@@ -147,6 +147,7 @@ void AppListMainView::PreloadIcons(PaginationModel* pagination_model,
if (parent)
scale_factor = ui::GetScaleFactorForNativeView(parent);
+ float scale = ui::GetImageScale(scale_factor);
// |pagination_model| could have -1 as the initial selected page and
// assumes first page (i.e. index 0) will be used in this case.
const int selected_page = std::max(0, pagination_model->selected_page());
@@ -160,10 +161,10 @@ void AppListMainView::PreloadIcons(PaginationModel* pagination_model,
pending_icon_loaders_.clear();
for (int i = start_model_index; i < end_model_index; ++i) {
AppListItemModel* item = model_->apps()->GetItemAt(i);
- if (item->icon().HasRepresentation(scale_factor))
+ if (item->icon().HasRepresentation(scale))
continue;
- pending_icon_loaders_.push_back(new IconLoader(this, item, scale_factor));
+ pending_icon_loaders_.push_back(new IconLoader(this, item, scale));
}
}

Powered by Google App Engine
This is Rietveld 408576698