| Index: ui/base/resource/resource_bundle_unittest.cc
|
| diff --git a/ui/base/resource/resource_bundle_unittest.cc b/ui/base/resource/resource_bundle_unittest.cc
|
| index 6a7b2b7db9c15e0b2a5f40ee8b864b9ed822b2b1..8ed45218e3c480f563bf9ebf85ae44fadff55903 100644
|
| --- a/ui/base/resource/resource_bundle_unittest.cc
|
| +++ b/ui/base/resource/resource_bundle_unittest.cc
|
| @@ -433,6 +433,10 @@ TEST_F(ResourceBundleImageTest, GetRawDataResource) {
|
| // Test requesting image reps at various scale factors from the image returned
|
| // via ResourceBundle::GetImageNamed().
|
| TEST_F(ResourceBundleImageTest, GetImageNamed) {
|
| + std::vector<ScaleFactor> supported_factors;
|
| + supported_factors.push_back(SCALE_FACTOR_100P);
|
| + supported_factors.push_back(SCALE_FACTOR_200P);
|
| + test::ScopedSetSupportedScaleFactors scoped_supported(supported_factors);
|
| base::FilePath data_1x_path = dir_path().AppendASCII("sample_1x.pak");
|
| base::FilePath data_2x_path = dir_path().AppendASCII("sample_2x.pak");
|
|
|
| @@ -451,29 +455,38 @@ TEST_F(ResourceBundleImageTest, GetImageNamed) {
|
|
|
| #if defined(OS_CHROMEOS)
|
| // ChromeOS loads highest scale factor first.
|
| - EXPECT_EQ(ui::SCALE_FACTOR_200P, image_skia->image_reps()[0].scale_factor());
|
| + EXPECT_EQ(ui::SCALE_FACTOR_200P,
|
| + GetScaleFactorFromScale(image_skia->image_reps()[0].scale()));
|
| #else
|
| - EXPECT_EQ(ui::SCALE_FACTOR_100P, image_skia->image_reps()[0].scale_factor());
|
| + EXPECT_EQ(ui::SCALE_FACTOR_100P,
|
| + GetScaleFactorFromScale(image_skia->image_reps()[0].scale()));
|
| #endif
|
|
|
| // Resource ID 3 exists in both 1x and 2x paks. Image reps should be
|
| // available for both scale factors in |image_skia|.
|
| gfx::ImageSkiaRep image_rep =
|
| - image_skia->GetRepresentation(ui::SCALE_FACTOR_100P);
|
| - EXPECT_EQ(ui::SCALE_FACTOR_100P, image_rep.scale_factor());
|
| - image_rep = image_skia->GetRepresentation(ui::SCALE_FACTOR_200P);
|
| - EXPECT_EQ(ui::SCALE_FACTOR_200P, image_rep.scale_factor());
|
| + image_skia->GetRepresentation(GetScaleFactorScale(ui::SCALE_FACTOR_100P));
|
| + EXPECT_EQ(ui::SCALE_FACTOR_100P, GetScaleFactorFromScale(image_rep.scale()));
|
| + image_rep =
|
| + image_skia->GetRepresentation(GetScaleFactorScale(ui::SCALE_FACTOR_200P));
|
| + EXPECT_EQ(ui::SCALE_FACTOR_200P, GetScaleFactorFromScale(image_rep.scale()));
|
|
|
| // The 1.4x pack was not loaded. Requesting the 1.4x resource should return
|
| // either the 1x or the 2x resource.
|
| - image_rep = image_skia->GetRepresentation(ui::SCALE_FACTOR_140P);
|
| - EXPECT_TRUE(image_rep.scale_factor() == ui::SCALE_FACTOR_100P ||
|
| - image_rep.scale_factor() == ui::SCALE_FACTOR_200P);
|
| + image_rep = image_skia->GetRepresentation(
|
| + ui::GetScaleFactorScale(ui::SCALE_FACTOR_140P));
|
| + ui::ScaleFactor scale_factor = GetScaleFactorFromScale(image_rep.scale());
|
| + EXPECT_TRUE(scale_factor == ui::SCALE_FACTOR_100P ||
|
| + scale_factor == ui::SCALE_FACTOR_200P);
|
| }
|
|
|
| // Test that GetImageNamed() behaves properly for images which GRIT has
|
| // annotated as having fallen back to 1x.
|
| TEST_F(ResourceBundleImageTest, GetImageNamedFallback1x) {
|
| + std::vector<ScaleFactor> supported_factors;
|
| + supported_factors.push_back(SCALE_FACTOR_100P);
|
| + supported_factors.push_back(SCALE_FACTOR_200P);
|
| + test::ScopedSetSupportedScaleFactors scoped_supported(supported_factors);
|
| base::FilePath data_path = dir_path().AppendASCII("sample.pak");
|
| base::FilePath data_2x_path = dir_path().AppendASCII("sample_2x.pak");
|
|
|
| @@ -495,8 +508,8 @@ TEST_F(ResourceBundleImageTest, GetImageNamedFallback1x) {
|
| // The image rep for 2x should be available. It should be resized to the
|
| // proper 2x size.
|
| gfx::ImageSkiaRep image_rep =
|
| - image_skia->GetRepresentation(ui::SCALE_FACTOR_200P);
|
| - EXPECT_EQ(ui::SCALE_FACTOR_200P, image_rep.scale_factor());
|
| + image_skia->GetRepresentation(GetScaleFactorScale(ui::SCALE_FACTOR_200P));
|
| + EXPECT_EQ(ui::SCALE_FACTOR_200P, GetScaleFactorFromScale(image_rep.scale()));
|
| EXPECT_EQ(20, image_rep.pixel_width());
|
| EXPECT_EQ(20, image_rep.pixel_height());
|
| }
|
| @@ -527,9 +540,11 @@ TEST_F(ResourceBundleImageTest, GetImageNamedFallback1xRounding) {
|
| // Non-integer dimensions should be rounded up.
|
| gfx::ImageSkia* image_skia = resource_bundle->GetImageSkiaNamed(3);
|
| gfx::ImageSkiaRep image_rep =
|
| - image_skia->GetRepresentation(ui::SCALE_FACTOR_140P);
|
| + image_skia->GetRepresentation(
|
| + GetScaleFactorScale(ui::SCALE_FACTOR_140P));
|
| EXPECT_EQ(12, image_rep.pixel_width());
|
| - image_rep = image_skia->GetRepresentation(ui::SCALE_FACTOR_180P);
|
| + image_rep = image_skia->GetRepresentation(
|
| + GetScaleFactorScale(ui::SCALE_FACTOR_180P));
|
| EXPECT_EQ(15, image_rep.pixel_width());
|
| }
|
| #endif
|
| @@ -547,7 +562,7 @@ TEST_F(ResourceBundleImageTest, FallbackToNone) {
|
| gfx::ImageSkia* image_skia = resource_bundle->GetImageSkiaNamed(3);
|
| EXPECT_EQ(1u, image_skia->image_reps().size());
|
| EXPECT_EQ(ui::SCALE_FACTOR_100P,
|
| - image_skia->image_reps()[0].scale_factor());
|
| + GetScaleFactorFromScale(image_skia->image_reps()[0].scale()));
|
| }
|
|
|
| } // namespace ui
|
|
|