Remove dependency on ui::ScaleFactor from ui/gfx

Remove dependency on ui::ScaleFactor from ui/gfx

As part of the work to removed dependencies on ui/base from ui/gfx I have
changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
to take float scale values instead of ui::ScaleFactor.

The notion of supported scale factors has been broken into 2 parts.
ui::SetSupportedScaleFactors remains and calls the
new ImageSkia::SetSupportedScales().

The initialization of the supported scale factors has been moved from layout.h
into ResourceBundle, and is done explicitly in tests that don't use
ResourceBundle.

BUG=103304
R=ben@chromium.org, oshima@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224473

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224876

[sky, 2013-09-16 22:51:45]

As you discussed this with Ben more than me:
-sky
+ben

[Ben Goodger (Google), 2013-09-16 23:10:30]

https://codereview.chromium.org/24175004/diff/1/cc/layers/layer.cc
File cc/layers/layer.cc (right):

https://codereview.chromium.org/24175004/diff/1/cc/layers/layer.cc#newcode23
cc/layers/layer.cc:23: #include "ui/base/layout.h"
why do you need this?

https://codereview.chromium.org/24175004/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_icon_image.h (right):

https://codereview.chromium.org/24175004/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_icon_image.h:16: #include "ui/base/layout.h"
?

https://codereview.chromium.org/24175004/diff/1/ui/views/controls/button/imag...
File ui/views/controls/button/image_button.h (right):

https://codereview.chromium.org/24175004/diff/1/ui/views/controls/button/imag...
ui/views/controls/button/image_button.h:10: #include "ui/base/layout.h"
? lots of these in this CL. are they necessary?

https://codereview.chromium.org/24175004/diff/1/ui/views/controls/menu/menu_w...
File ui/views/controls/menu/menu_win.cc (right):

https://codereview.chromium.org/24175004/diff/1/ui/views/controls/menu/menu_w...
ui/views/controls/menu/menu_win.cc:16: #include "ui/base/layout.h"
etc

https://codereview.chromium.org/24175004/diff/1/ui/views/controls/menu/native...
File ui/views/controls/menu/native_menu_win.cc (right):

https://codereview.chromium.org/24175004/diff/1/ui/views/controls/menu/native...
ui/views/controls/menu/native_menu_win.cc:19: #include "ui/base/layout.h"
etc

[DaveMoore, 2013-09-17 00:05:39]

Rename methods and vars to make image_scale more clear

[Ben Goodger (Google), 2013-09-17 17:00:43]

Dave got me to understand the includes. Basically just identifies further
refactoring tasks.

LGTM.

[oshima, 2013-09-17 17:31:19]

lgtm with nits

https://codereview.chromium.org/24175004/diff/9001/chrome/browser/profiles/pr...
File chrome/browser/profiles/profile_info_util.cc (right):

https://codereview.chromium.org/24175004/diff/9001/chrome/browser/profiles/pr...
chrome/browser/profiles/profile_info_util.cc:104: } // namespace profiles
nit: two spaces

https://codereview.chromium.org/24175004/diff/9001/ui/gfx/canvas.h
File ui/gfx/canvas.h (right):

https://codereview.chromium.org/24175004/diff/9001/ui/gfx/canvas.h#newcode96
ui/gfx/canvas.h:96: // Creates canvas with provided DIP |size| and
|image_scale_|.
nit: |image_scale|

https://codereview.chromium.org/24175004/diff/9001/ui/gfx/canvas.h#newcode108
ui/gfx/canvas.h:108: // |sk_canvas| is assumed to be already scaled based on
|image_scale_|
ditto

https://codereview.chromium.org/24175004/diff/9001/ui/gfx/canvas.h#newcode113
ui/gfx/canvas.h:113: // Recreates the backing platform canvas with DIP |size|
and |image_scale_|.
ditto

https://codereview.chromium.org/24175004/diff/9001/ui/gfx/image/image_ios.mm
File ui/gfx/image/image_ios.mm (right):

https://codereview.chromium.org/24175004/diff/9001/ui/gfx/image/image_ios.mm#...
ui/gfx/image/image_ios.mm:77: float ideal_scale =
ImageSkia::GetSupportedScales().back();
ImageSkia::GetMaxSupportedScale()

https://codereview.chromium.org/24175004/diff/9001/ui/gfx/image/image_unittes...
File ui/gfx/image/image_unittest_util.cc (right):

https://codereview.chromium.org/24175004/diff/9001/ui/gfx/image/image_unittes...
ui/gfx/image/image_unittest_util.cc:183: float scale =
ImageSkia::GetSupportedScales().back();
nit ImageSkia::GetMaxSupportedScales()

[DaveMoore, 2013-09-20 20:21:11]

Committed patchset #3 manually as r224473 (presubmit successful).

[DaveMoore, 2013-09-20 23:00:25]

Try to fix android test failure

[DaveMoore, 2013-09-23 21:19:32]

Fix new usage of scale in FastShowPickler

[DaveMoore, 2013-09-23 21:32:05]

Fix new usage of scale in FastShowPickler

[DaveMoore, 2013-09-23 22:20:46]

Fix new usage of scale in FastShowPickler

[DaveMoore, 2013-09-24 03:26:02]

Committed patchset #8 manually as r224876 (presubmit successful).