Fix crash caused by stale WebContents in chrome://interstitials

Fix crash caused by stale WebContents in chrome://interstitials

InterstitialHTMLSource provides the data for this page using the
wrong WebContents. This isn't a problem when the links are opened in the
same tab. However, when a link is opened in a new tab, web_contents_ of
IntersititalHTMLSource is assigned to the new tab. When the tab is destroyed,
future data requests are made using the stale web_contents and cause a crash.

Instead, simply use the WebContents provided in
InterstitialHTMLSource::StartDataRequest.

BUG=611706
Committed: https://crrev.com/861833fc6f49583b3fb052c6711c3733d1478a42
Cr-Commit-Position: refs/heads/master@{#425185}

[meacer, 2016-10-13 19:53:27]

Description was changed from

==========
Fix crash caused by stale WebContents in chrome://interstitials

InterstitialHTMLSource that provides the data for this page uses the
wrong WebContents. This isn't a problem when the links are opened in the
same tab. However, when a link is opened in a new tab, web_contents_ of
IntersititalHTMLSource is assigned to the new tab. When the tab is destroyed,
future data requests are made using this stale web_contents and cause a crash.

Instead, simply use the WebContents provided in
InterstitialHTMLSource::StartDataRequest.

BUG=611706
==========

to

==========
Fix crash caused by stale WebContents in chrome://interstitials

InterstitialHTMLSource provides the data for this page using the
wrong WebContents. This isn't a problem when the links are opened in the
same tab. However, when a link is opened in a new tab, web_contents_ of
IntersititalHTMLSource is assigned to the new tab. When the tab is destroyed,
future data requests are made using the stale web_contents and cause a crash.

Instead, simply use the WebContents provided in
InterstitialHTMLSource::StartDataRequest.

BUG=611706
==========

[meacer, 2016-10-13 19:54:57]

meacer@chromium.org changed reviewers:
+ estark@chromium.org

[meacer, 2016-10-13 19:54:57]

estark: PTAL? Thanks.

[meacer, 2016-10-13 20:21:47]

The CQ bit was checked by meacer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 20:22:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 21:08:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 21:08:30]

Dry run: This issue passed the CQ dry run.

[estark, 2016-10-13 21:14:09]

lgtm but how hard would it be to write a regression test?

[meacer, 2016-10-13 21:18:30]

On 2016/10/13 21:14:09, estark wrote:
> lgtm but how hard would it be to write a regression test?

There are browser tests for this code but they are disabled
(interstitial_ui_browsertest.cc). How about I try reenabling them and and a
regression test for this in another CL?

[estark, 2016-10-13 21:19:54]

On 2016/10/13 21:18:30, Mustafa Emre Acer wrote:
> On 2016/10/13 21:14:09, estark wrote:
> > lgtm but how hard would it be to write a regression test?
> 
> There are browser tests for this code but they are disabled
> (interstitial_ui_browsertest.cc). How about I try reenabling them and and a
> regression test for this in another CL?

Ok, sgtm

[meacer, 2016-10-13 21:23:13]

The CQ bit was checked by meacer@chromium.org

[meacer, 2016-10-13 21:23:23]

The CQ bit was unchecked by meacer@chromium.org

[meacer, 2016-10-13 22:09:24]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2016-10-13 22:09:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 22:15:54]

Description was changed from

==========
Fix crash caused by stale WebContents in chrome://interstitials

InterstitialHTMLSource provides the data for this page using the
wrong WebContents. This isn't a problem when the links are opened in the
same tab. However, when a link is opened in a new tab, web_contents_ of
IntersititalHTMLSource is assigned to the new tab. When the tab is destroyed,
future data requests are made using the stale web_contents and cause a crash.

Instead, simply use the WebContents provided in
InterstitialHTMLSource::StartDataRequest.

BUG=611706
==========

to

==========
Fix crash caused by stale WebContents in chrome://interstitials

InterstitialHTMLSource provides the data for this page using the
wrong WebContents. This isn't a problem when the links are opened in the
same tab. However, when a link is opened in a new tab, web_contents_ of
IntersititalHTMLSource is assigned to the new tab. When the tab is destroyed,
future data requests are made using the stale web_contents and cause a crash.

Instead, simply use the WebContents provided in
InterstitialHTMLSource::StartDataRequest.

BUG=611706
==========

[commit-bot: I haz the power, 2016-10-13 22:15:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-13 22:19:19]

Description was changed from

==========
Fix crash caused by stale WebContents in chrome://interstitials

InterstitialHTMLSource provides the data for this page using the
wrong WebContents. This isn't a problem when the links are opened in the
same tab. However, when a link is opened in a new tab, web_contents_ of
IntersititalHTMLSource is assigned to the new tab. When the tab is destroyed,
future data requests are made using the stale web_contents and cause a crash.

Instead, simply use the WebContents provided in
InterstitialHTMLSource::StartDataRequest.

BUG=611706
==========

to

==========
Fix crash caused by stale WebContents in chrome://interstitials

InterstitialHTMLSource provides the data for this page using the
wrong WebContents. This isn't a problem when the links are opened in the
same tab. However, when a link is opened in a new tab, web_contents_ of
IntersititalHTMLSource is assigned to the new tab. When the tab is destroyed,
future data requests are made using the stale web_contents and cause a crash.

Instead, simply use the WebContents provided in
InterstitialHTMLSource::StartDataRequest.

BUG=611706

Committed: https://crrev.com/861833fc6f49583b3fb052c6711c3733d1478a42
Cr-Commit-Position: refs/heads/master@{#425185}
==========

[commit-bot: I haz the power, 2016-10-13 22:19:20]

Patchset 1 (id:??) landed as
https://crrev.com/861833fc6f49583b3fb052c6711c3733d1478a42
Cr-Commit-Position: refs/heads/master@{#425185}