Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tools/gn/args.cc

Issue 2417443002: GN: Add PPC/s390 Linux support (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/build_config.h ('k') | tools/gn/bootstrap/bootstrap.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/args.cc
diff --git a/tools/gn/args.cc b/tools/gn/args.cc
index 9aaafb0854da7ca28ec08360eebb01e1ac858671..72480f527882a7cba6fb814326132a3f937f1110 100644
--- a/tools/gn/args.cc
+++ b/tools/gn/args.cc
@@ -269,6 +269,8 @@ void Args::SetSystemVarsLocked(Scope* dest) const {
static const char kX64[] = "x64";
static const char kArm[] = "arm";
static const char kMips[] = "mipsel";
+ static const char kS390X[] = "s390x";
+ static const char kPPC64[] = "ppc64";
const char* arch = nullptr;
// Set the host CPU architecture based on the underlying OS, not
@@ -282,8 +284,12 @@ void Args::SetSystemVarsLocked(Scope* dest) const {
arch = kArm;
else if (os_arch == "mips")
arch = kMips;
+ else if (os_arch == "s390x")
+ arch = kS390X;
+ else if (os_arch == "mips")
+ arch = kPPC64;
else
- CHECK(false) << "OS architecture not handled.";
+ CHECK(false) << "OS architecture not handled. (" << os_arch << ")";
// Save the OS and architecture as build arguments that are implicitly
// declared. This is so they can be overridden in a toolchain build args
« no previous file with comments | « build/build_config.h ('k') | tools/gn/bootstrap/bootstrap.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698