Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2417443002: GN: Add PPC/s390 Linux support (Closed)

Created:
4 years, 2 months ago by JaideepBajwa
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org, JoranSiu, john.yan, michael_dawson
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add PPC/s390 Linux support Adding ppc/s390 architecture support to build config and bootstrap.py to be able build GN binary. BUG= R=dpranke@chromium.org, brettw@chromium.org Committed: https://crrev.com/fbf038170dc0bd29ead8630013b28c6008047ec1 Cr-Commit-Position: refs/heads/master@{#425502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M base/debug/debugger_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M build/build_config.h View 1 chunk +25 lines, -0 lines 0 comments Download
M tools/gn/args.cc View 2 chunks +7 lines, -1 line 0 comments Download
M tools/gn/bootstrap/bootstrap.py View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
JaideepBajwa
PTAL
4 years, 2 months ago (2016-10-12 00:26:54 UTC) #1
Dirk Pranke
This lgtm but brettw@ needs to review it as well.
4 years, 2 months ago (2016-10-12 00:31:13 UTC) #2
brettw
lgtm
4 years, 2 months ago (2016-10-14 18:05:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417443002/1
4 years, 2 months ago (2016-10-14 19:02:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 23:02:37 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 23:05:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbf038170dc0bd29ead8630013b28c6008047ec1
Cr-Commit-Position: refs/heads/master@{#425502}

Powered by Google App Engine
This is Rietveld 408576698