Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2417403003: [devil] Pick a free port for adb daemon server when port 5037 is in used (Closed)

Created:
4 years, 2 months ago by nednguyen
Modified:
4 years, 2 months ago
Reviewers:
perejzu, jbudorick
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use constant param for 5037 #

Patch Set 3 : Stringify the port number in command args #

Patch Set 4 : Only use random port when first adb command failed due to address already in used #

Patch Set 5 : Remove unused const #

Patch Set 6 : Fix linting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M devil/devil/android/sdk/adb_wrapper.py View 1 2 3 4 5 5 chunks +35 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
nednguyen
Sorry for TBR'ed this controversial fix :-( Please feel free to revert this if you ...
4 years, 2 months ago (2016-10-15 17:01:46 UTC) #1
nednguyen
On 2016/10/15 17:01:46, nednguyen wrote: > Sorry for TBR'ed this controversial fix but all the ...
4 years, 2 months ago (2016-10-15 17:02:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417403003/20001
4 years, 2 months ago (2016-10-15 17:04:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Android%20Tryserver/builds/1717)
4 years, 2 months ago (2016-10-15 17:06:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417403003/40001
4 years, 2 months ago (2016-10-15 17:11:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417403003/60001
4 years, 2 months ago (2016-10-15 17:33:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417403003/100001
4 years, 2 months ago (2016-10-15 17:38:04 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6591274a9ba824d476ec249a329627ef2038eb6f
4 years, 2 months ago (2016-10-15 17:59:02 UTC) #16
nednguyen
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2420253003/ by nednguyen@google.com. ...
4 years, 2 months ago (2016-10-15 22:55:35 UTC) #17
jbudorick
4 years, 2 months ago (2016-10-18 17:34:58 UTC) #18
Message was sent while issue was closed.
Thanks for reverting. Please don't land a change like this in the future w/o
getting a review from a devil owner first, though.

Powered by Google App Engine
This is Rietveld 408576698