Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: components/metrics/proto/memory_leak_report.proto

Issue 2417403002: Revert of Leak reports collect information about the last uptrend (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 syntax = "proto2"; 5 syntax = "proto2";
6 6
7 option optimize_for = LITE_RUNTIME; 7 option optimize_for = LITE_RUNTIME;
8 8
9 package metrics; 9 package metrics;
10 10
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 // allocation. The oldest record is at the beginning. The most recent record, 102 // allocation. The oldest record is at the beginning. The most recent record,
103 // taken at the time the report was generated, is at the end. 103 // taken at the time the report was generated, is at the end.
104 repeated AllocationBreakdown alloc_breakdown_history = 4; 104 repeated AllocationBreakdown alloc_breakdown_history = 4;
105 105
106 // The following two fields describe the last increasing trend in the number 106 // The following two fields describe the last increasing trend in the number
107 // of allocations from the size and call stack that generated this 107 // of allocations from the size and call stack that generated this
108 // leak report. 108 // leak report.
109 // 109 //
110 // |num_rising_intervals| equals timeslot_now - timeslot_drop, 110 // |num_rising_intervals| equals timeslot_now - timeslot_drop,
111 // where timeslot_drop is the timeslot number of the last frame that saw 111 // where timeslot_drop is the timeslot number of the last frame that saw
112 // a drop in the number of allocations, or the first frame in the history 112 // a drop in the number of allocations (or 0 if there were no drops).
113 // if there were no drops (history is cleared when the net number of
114 // allocations hits 0).
115 // If it is < 32, it will be visible in the allocation history graph. 113 // If it is < 32, it will be visible in the allocation history graph.
116 // If it is >= 32, it will not be seen in the graph. 114 // If it is >= 32, it will not be seen in the graph.
117 // E.g. for history [3,2,4,4,7] |num_rising_intervals| equals 3. 115 // E.g. for history [3,2,4,4,7] |num_rising_intervals| equals 3.
118 optional uint32 num_rising_intervals = 7; 116 optional uint32 num_rising_intervals = 7;
119 117
120 // Indicates the magnitude of the current uptrend in allocations. 118 // Indicates the magnitude of the current uptrend in allocations.
121 // E.g. for history [3,2,4,4,7] |num_allocs_increase| equals 5. 119 // E.g. for history [3,2,4,4,7] |num_allocs_increase| equals 5.
122 optional uint32 num_allocs_increase = 8; 120 optional uint32 num_allocs_increase = 8;
123 121
124 ////////////////////////////////////////////////////////////////////////////// 122 //////////////////////////////////////////////////////////////////////////////
125 123
126 // Contains additional data about the memory usage from the OS. 124 // Contains additional data about the memory usage from the OS.
127 // There is no need to store the total system memory as it is 125 // There is no need to store the total system memory as it is
128 // available under SystemProfileProto::Hardware::system_ram_mb. 126 // available under SystemProfileProto::Hardware::system_ram_mb.
129 // 127 //
130 // Next tag: 3 128 // Next tag: 3
131 message MemoryUsageInfo { 129 message MemoryUsageInfo {
132 // How much available physical memory the system has. 130 // How much available physical memory the system has.
133 optional uint64 available_ram_mb = 1; 131 optional uint64 available_ram_mb = 1;
134 132
135 // Total private working set memory across all Chrome processes. 133 // Total private working set memory across all Chrome processes.
136 optional uint64 chrome_ram_usage_mb = 2; 134 optional uint64 chrome_ram_usage_mb = 2;
137 } 135 }
138 136
139 // Information about the memory usage from the OS collected right after 137 // Information about the memory usage from the OS collected right after
140 // the leak report was created in the leak detector. 138 // the leak report was created in the leak detector.
141 optional MemoryUsageInfo memory_usage_info = 9; 139 optional MemoryUsageInfo memory_usage_info = 9;
142 } 140 }
OLDNEW
« no previous file with comments | « components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698