Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2501)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 2417213002: [Android WebView] Call AwGLFunctor.onDetachedFromWindow with correct order. (Closed)
Patch Set: [Android WebView] Call AwGLFunctor.onDetachedFromWindow with correct order. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 6735b00476a4700c1d3b8bce923ce04db846676d..17478ed0df8a0ec7f50d40f3577e029480d6a379 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -3161,12 +3161,15 @@ public class AwContents implements SmartClipProvider,
}
mIsAttachedToWindow = false;
hideAutofillPopup();
+ // AwGLFunctor.onDetachedFromWindow should be called before nativeOnDetachedFromWindow
+ // to make sure resources are released immediately after detach.
+ mCurrentFunctor.onDetachedFromWindow();
+
nativeOnDetachedFromWindow(mNativeAwContents);
mContentViewCore.onDetachedFromWindow();
updateHardwareAcceleratedFeaturesToggle();
postUpdateContentViewCoreVisibility();
- mCurrentFunctor.onDetachedFromWindow();
if (mComponentCallbacks != null) {
mContext.unregisterComponentCallbacks(mComponentCallbacks);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698