Loading: bulk style errors fix in core/fetch

Loading: bulk style errors fix in core/fetch

This patch fixes style errors on core/fetch that happens probably after
the cl-format changes. This fix will help to avoid from hidding
important presubmit warnings/errors in the middle of refactoring works.

(*1): Style check still shows one error, but it needs non-mechanical
changes that will make different binary. So I do not want to contain
the fix for it in this change.

TEST=./Tools/Script/check-webkit-style Source/core/fetch  (*1)
TEST=ninja -C out/Release all
BUG=655920
Committed: https://crrev.com/3a85520418a62d27bdb5fc4e5356c88e2bd459d1
Cr-Commit-Position: refs/heads/master@{#425272}

[Takashi Toyoshima, 2016-10-14 06:38:21]

Description was changed from

==========
Loading: bulk style errors fix in core/fetch

This patch fixes style errors on core/fetch that happens probably after
the cl-format changes. This fix will help to avoid from hidding
important presubmit warnings/errors in the middle of refactoring works.

(*1): Style check still shows one error, but it needs non-mechanical
changes that will make different binary. So I do not want to contain
the fix for it in this change.

TEST=./Tools/Script/check-webkit-style Source/core/fetch  (*1)
TEST=ninja -C out/Release all
BUG=655920
==========

to

==========
Loading: bulk style errors fix in core/fetch

This patch fixes style errors on core/fetch that happens probably after
the cl-format changes. This fix will help to avoid from hidding
important presubmit warnings/errors in the middle of refactoring works.

(*1): Style check still shows one error, but it needs non-mechanical
changes that will make different binary. So I do not want to contain
the fix for it in this change.

TEST=./Tools/Script/check-webkit-style Source/core/fetch  (*1)
TEST=ninja -C out/Release all
BUG=655920
==========

[Takashi Toyoshima, 2016-10-14 06:38:21]

toyoshim@chromium.org changed reviewers:
+ dcheng@chromium.org, kouhei@chromium.org

[Takashi Toyoshima, 2016-10-14 06:38:32]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 06:38:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-10-14 06:39:16]

PTAL, this is core/fetch version of https://codereview.chromium.org/2415373002/

[dcheng, 2016-10-14 06:41:53]

LGTM with a nit

https://codereview.chromium.org/2417173002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/FetchContext.cpp (right):

https://codereview.chromium.org/2417173002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/FetchContext.cpp:32: 
Nit: remove this extra line: check-webkit-style shouldn't complain about this,
and we generally group all the user includes in one block, system C headers in
another, and system C++ headers in a third separate block.

[kouhei (in TOK), 2016-10-14 06:43:28]

lgtm

[Takashi Toyoshima, 2016-10-14 07:04:44]

https://codereview.chromium.org/2417173002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/FetchContext.cpp (right):

https://codereview.chromium.org/2417173002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/FetchContext.cpp:32: 
This caused an error like this.

> third_party/WebKit/Source/core/fetch/FetchContext.cpp:31:  You should add a
blank line after implementation file's own header.  [build/include_order] [4]

[dcheng, 2016-10-14 07:07:31]

On 2016/10/14 07:04:44, toyoshim wrote:
>
https://codereview.chromium.org/2417173002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/fetch/FetchContext.cpp (right):
> 
>
https://codereview.chromium.org/2417173002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/fetch/FetchContext.cpp:32: 
> This caused an error like this.
> 
> > third_party/WebKit/Source/core/fetch/FetchContext.cpp:31:  You should add a
> blank line after implementation file's own header.  [build/include_order] [4]

Ah, I missed that, sorry. This is fine then.

[commit-bot: I haz the power, 2016-10-14 07:43:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 07:43:15]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2016-10-14 08:00:02]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-10-14 08:00:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 08:07:16]

Description was changed from

==========
Loading: bulk style errors fix in core/fetch

This patch fixes style errors on core/fetch that happens probably after
the cl-format changes. This fix will help to avoid from hidding
important presubmit warnings/errors in the middle of refactoring works.

(*1): Style check still shows one error, but it needs non-mechanical
changes that will make different binary. So I do not want to contain
the fix for it in this change.

TEST=./Tools/Script/check-webkit-style Source/core/fetch  (*1)
TEST=ninja -C out/Release all
BUG=655920
==========

to

==========
Loading: bulk style errors fix in core/fetch

This patch fixes style errors on core/fetch that happens probably after
the cl-format changes. This fix will help to avoid from hidding
important presubmit warnings/errors in the middle of refactoring works.

(*1): Style check still shows one error, but it needs non-mechanical
changes that will make different binary. So I do not want to contain
the fix for it in this change.

TEST=./Tools/Script/check-webkit-style Source/core/fetch  (*1)
TEST=ninja -C out/Release all
BUG=655920
==========

[commit-bot: I haz the power, 2016-10-14 08:07:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-14 08:10:48]

Description was changed from

==========
Loading: bulk style errors fix in core/fetch

This patch fixes style errors on core/fetch that happens probably after
the cl-format changes. This fix will help to avoid from hidding
important presubmit warnings/errors in the middle of refactoring works.

(*1): Style check still shows one error, but it needs non-mechanical
changes that will make different binary. So I do not want to contain
the fix for it in this change.

TEST=./Tools/Script/check-webkit-style Source/core/fetch  (*1)
TEST=ninja -C out/Release all
BUG=655920
==========

to

==========
Loading: bulk style errors fix in core/fetch

This patch fixes style errors on core/fetch that happens probably after
the cl-format changes. This fix will help to avoid from hidding
important presubmit warnings/errors in the middle of refactoring works.

(*1): Style check still shows one error, but it needs non-mechanical
changes that will make different binary. So I do not want to contain
the fix for it in this change.

TEST=./Tools/Script/check-webkit-style Source/core/fetch  (*1)
TEST=ninja -C out/Release all
BUG=655920

Committed: https://crrev.com/3a85520418a62d27bdb5fc4e5356c88e2bd459d1
Cr-Commit-Position: refs/heads/master@{#425272}
==========

[commit-bot: I haz the power, 2016-10-14 08:10:49]

Patchset 1 (id:??) landed as
https://crrev.com/3a85520418a62d27bdb5fc4e5356c88e2bd459d1
Cr-Commit-Position: refs/heads/master@{#425272}