Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2417143003: Add UMA reporting of reset request origin. (Closed)

Created:
4 years, 2 months ago by alito
Modified:
4 years, 2 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, asvitkine+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA reporting of reset request origin. BUG=656659 Committed: https://crrev.com/4cfde1e0de77f7b5e68fa93b3d0c5a77c1ae5b98 Cr-Commit-Position: refs/heads/master@{#425736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -15 lines) Patch
M chrome/browser/profile_resetter/profile_reset_report.proto View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/reset_profile_settings_handler.h View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/reset_profile_settings_handler.cc View 5 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/settings/reset_settings_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
alito
I'm adding the reset request origin to UMA. Owners, PTAL. asvitkine: tools/metrics/histograms/histograms.xml dbeam: chrome/browser/ui/webui/options/reset_profile_settings_handler.cc chrome/browser/ui/webui/options/reset_profile_settings_handler.h ...
4 years, 2 months ago (2016-10-14 22:46:25 UTC) #2
battre
lgtm
4 years, 2 months ago (2016-10-17 07:02:37 UTC) #3
Alexei Svitkine (slow)
lgtm, but please file a crbug and associate BUG= since it's not something super trivial ...
4 years, 2 months ago (2016-10-17 15:25:55 UTC) #5
alito
Added a bug to the CL.
4 years, 2 months ago (2016-10-17 15:41:11 UTC) #7
Dan Beam
lgtm
4 years, 2 months ago (2016-10-17 17:14:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417143003/1
4 years, 2 months ago (2016-10-17 17:19:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 18:56:32 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 18:59:25 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4cfde1e0de77f7b5e68fa93b3d0c5a77c1ae5b98
Cr-Commit-Position: refs/heads/master@{#425736}

Powered by Google App Engine
This is Rietveld 408576698