Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 241713003: Add run_mojo_python_tests.py so that we can run the python tests on the bots. (Closed)

Created:
6 years, 8 months ago by Dirk Pranke
Modified:
6 years, 8 months ago
Reviewers:
viettrungluu, sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium, sky
Visibility:
Public.

Description

Add run_mojo_python_tests.py so that we can run the python tests on the bots. The bots would strongly prefer to call python directly rather than route through the mojob.sh shell script. R=viettrungluu@chromium.org, sky@chromium.org BUG=364709 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264743

Patch Set 1 : patch for review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M mojo/tools/mojob.sh View 1 chunk +1 line, -3 lines 1 comment Download
A mojo/tools/run_mojo_python_tests.py View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dirk Pranke
Either Trung or Scott, please take a look?
6 years, 8 months ago (2014-04-17 23:07:35 UTC) #1
Dirk Pranke
https://codereview.chromium.org/241713003/diff/20001/mojo/tools/mojob.sh File mojo/tools/mojob.sh (right): https://codereview.chromium.org/241713003/diff/20001/mojo/tools/mojob.sh#newcode115 mojo/tools/mojob.sh:115: cd "$(realpath "$(dirname "$0")")/../.." Dunno if you guys care, ...
6 years, 8 months ago (2014-04-17 23:08:05 UTC) #2
sky
LGTM
6 years, 8 months ago (2014-04-17 23:14:07 UTC) #3
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 8 months ago (2014-04-17 23:37:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/241713003/20001
6 years, 8 months ago (2014-04-17 23:37:56 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 05:25:50 UTC) #6
Message was sent while issue was closed.
Change committed as 264743

Powered by Google App Engine
This is Rietveld 408576698